2006-03-17 08:24:48

by Yasunori Goto

Subject: [PATCH: 017/017]Memory hotplug for new nodes v.4.(arch_register_node() for ia64)

This is to create sysfs file for new node.
It adds arch specific functions 'arch_register_node()'
and 'arch_unregister_node()' to IA64 to call the generic
function 'register_node()' and 'unregister_node()' respectively.


Signed-off-by: Keiichiro Tokunaga <[email protected]>
Signed-off-by: Yasunori Goto <[email protected]>

arch/ia64/kernel/topology.c | 15 +++++++++++++++
include/linux/node.h | 2 ++
2 files changed, 17 insertions(+)

Index: pgdat8/arch/ia64/kernel/topology.c
===================================================================
--- pgdat8.orig/arch/ia64/kernel/topology.c 2006-03-16 16:04:54.000000000 +0900
+++ pgdat8/arch/ia64/kernel/topology.c 2006-03-16 16:06:27.000000000 +0900
@@ -65,6 +65,21 @@ EXPORT_SYMBOL(arch_register_cpu);
EXPORT_SYMBOL(arch_unregister_cpu);
#endif /*CONFIG_HOTPLUG_CPU*/

+#ifdef CONFIG_NUMA
+int arch_register_node(int num)
+{
+ if (sysfs_nodes[num].sysdev.id == num)
+ return 0;
+
+ return register_node(&sysfs_nodes[num], num, 0);
+}
+
+void arch_unregister_node(int num)
+{
+ unregister_node(&sysfs_nodes[num]);
+ sysfs_nodes[num].sysdev.id = -1;
+}
+#endif

static int __init topology_init(void)
{
Index: pgdat8/include/linux/node.h
===================================================================
--- pgdat8.orig/include/linux/node.h 2006-03-16 16:04:54.000000000 +0900
+++ pgdat8/include/linux/node.h 2006-03-16 16:06:27.000000000 +0900
@@ -28,6 +28,8 @@ struct node {

extern int register_node(struct node *, int, struct node *);
extern void unregister_node(struct node *node);
+extern int arch_register_node(int num);
+extern void arch_unregister_node(int num);

#define to_node(sys_device) container_of(sys_device, struct node, sysdev)


--
Yasunori Goto

2006-03-17 18:01:34

by Dave Hansen

Subject: Re: [PATCH: 017/017]Memory hotplug for new nodes v.4.(arch_register_node() for ia64)

On Fri, 2006-03-17 at 17:23 +0900, Yasunori Goto wrote:
> +++ pgdat8/arch/ia64/kernel/topology.c 2006-03-16 16:06:27.000000000 +0900
> @@ -65,6 +65,21 @@ EXPORT_SYMBOL(arch_register_cpu);
> EXPORT_SYMBOL(arch_unregister_cpu);
> #endif /*CONFIG_HOTPLUG_CPU*/
>
> +#ifdef CONFIG_NUMA
> +int arch_register_node(int num)
> +{
> + if (sysfs_nodes[num].sysdev.id == num)
> + return 0;
> +
> + return register_node(&sysfs_nodes[num], num, 0);
> +}
> +
> +void arch_unregister_node(int num)
> +{
> + unregister_node(&sysfs_nodes[num]);
> + sysfs_nodes[num].sysdev.id = -1;
> +}
> +#endif

I don't have a real problem with you cluttering up ia64 code, but if
these are useful, why don't we put them in generic code? They seem
quite arch-independent to me.

-- Dave

2006-03-20 09:59:00

by Yasunori Goto

Subject: Re: [PATCH: 017/017]Memory hotplug for new nodes v.4.(arch_register_node() for ia64)

> On Fri, 2006-03-17 at 17:23 +0900, Yasunori Goto wrote:
> > +++ pgdat8/arch/ia64/kernel/topology.c 2006-03-16 16:06:27.000000000 +0900
> > @@ -65,6 +65,21 @@ EXPORT_SYMBOL(arch_register_cpu);
> > EXPORT_SYMBOL(arch_unregister_cpu);
> > #endif /*CONFIG_HOTPLUG_CPU*/
> >
> > +#ifdef CONFIG_NUMA
> > +int arch_register_node(int num)
> > +{
> > + if (sysfs_nodes[num].sysdev.id == num)
> > + return 0;
> > +
> > + return register_node(&sysfs_nodes[num], num, 0);
> > +}
> > +
> > +void arch_unregister_node(int num)
> > +{
> > + unregister_node(&sysfs_nodes[num]);
> > + sysfs_nodes[num].sysdev.id = -1;
> > +}
> > +#endif
>
> I don't have a real problem with you cluttering up ia64 code, but if
> these are useful, why don't we put them in generic code? They seem
> quite arch-independent to me.

I'm not sure they can be common code.

Current i386's code treats "parent node" in arch_register_node().
But, IA64 doesn't need it.

Bye.

--
Yasunori Goto

2006-03-20 16:40:35

by Dave Hansen

Subject: Re: [PATCH: 017/017]Memory hotplug for new nodes v.4.(arch_register_node() for ia64)

On Mon, 2006-03-20 at 18:57 +0900, Yasunori Goto wrote:
> Current i386's code treats "parent node" in arch_register_node().
> But, IA64 doesn't need it.

I'm not sure I understand. What do you mean by "treats"?

-- Dave

2006-03-21 04:13:03

by Yasunori Goto

Subject: Re: [PATCH: 017/017]Memory hotplug for new nodes v.4.(arch_register_node() for ia64)

> On Mon, 2006-03-20 at 18:57 +0900, Yasunori Goto wrote:
> > Current i386's code treats "parent node" in arch_register_node().
> > But, IA64 doesn't need it.
>
> I'm not sure I understand. What do you mean by "treats"?

Oops. My English may be wrong. :-(
I mean that i386 seems trying to make relationship of parent and child
among each node.

--
Yasunori Goto