2006-03-23 18:01:41

by Bernhard Rosenkraenzer

Subject: [PATCH] 2.6.16-mm1 x1205 RTC driver doesn't compile

rtc-x1205 uses I2C_DRIVERID_X1205 without defining it.

Signed-off-by: Bernhard Rosenkraenzer <[email protected]>

---
--- linux-2.6.16/include/linux/i2c-id.h.ark 2006-03-23 18:56:50.000000000
+0100
+++ linux-2.6.16/include/linux/i2c-id.h 2006-03-23 18:56:22.000000000 +0100
@@ -108,6 +108,7 @@
#define I2C_DRIVERID_UPD64083 78 /* upd64083 video processor */
#define I2C_DRIVERID_UPD64031A 79 /* upd64031a video processor */
#define I2C_DRIVERID_SAA717X 80 /* saa717x video encoder */
+#define I2C_DRIVERID_X1205 81 /* X1205 RTC */

#define I2C_DRIVERID_I2CDEV 900
#define I2C_DRIVERID_ARP 902 /* SMBus ARP Client */

2006-03-24 09:08:48

by Andrew Morton

Subject: Re: [PATCH] 2.6.16-mm1 x1205 RTC driver doesn't compile

Bernhard Rosenkraenzer <[email protected]> wrote:
>
> rtc-x1205 uses I2C_DRIVERID_X1205 without defining it.
>
> Signed-off-by: Bernhard Rosenkraenzer <[email protected]>
>
> ---
> --- linux-2.6.16/include/linux/i2c-id.h.ark 2006-03-23 18:56:50.000000000
> +0100
> +++ linux-2.6.16/include/linux/i2c-id.h 2006-03-23 18:56:22.000000000 +0100
> @@ -108,6 +108,7 @@
> #define I2C_DRIVERID_UPD64083 78 /* upd64083 video processor */
> #define I2C_DRIVERID_UPD64031A 79 /* upd64031a video processor */
> #define I2C_DRIVERID_SAA717X 80 /* saa717x video encoder */
> +#define I2C_DRIVERID_X1205 81 /* X1205 RTC */
>
> #define I2C_DRIVERID_I2CDEV 900
> #define I2C_DRIVERID_ARP 902 /* SMBus ARP Client */

But this ID was defined in
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.16/2.6.16-mm1/broken-out/rtc-subsystem-i2c-driver-ids.patch.
With a different ID, btw.

A patch reject at your end, I suspect.