2006-05-05 05:57:03

by Paul Mackerras

[permalink] [raw]
Subject: Re: [PATCH 07/13] powerpc: export symbols for page size selection

Arnd Bergmann writes:

> We need access to some symbols in powerpc memory management
> from spufs in order to create proper SLB entries.

I don't like exporting low-level implementation details like this, and
it seems a bit bogus to have an SLB miss handler in a module. Could
you move the SLB miss handler to the non-modular part?

Regards,
Paul.


2006-05-05 11:57:16

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH 07/13] powerpc: export symbols for page size selection

On Friday 05 May 2006 07:56, Paul Mackerras wrote:
> I don't like exporting low-level implementation details like this, and
> it seems a bit bogus to have an SLB miss handler in a module. ?Could
> you move the SLB miss handler to the non-modular part?

Yes. The series already has the patches to move the SLB miss handler
into the built-in parts. At the moment, we also need the symbols for
the context switch code that also touches the SLB entries. We already
have a patch to move that as well, but are still discussing the details
of that.

I'll follow up with a patch to replace this one.

Arnd <><