2006-05-09 08:56:22

by Chris Wright

[permalink] [raw]
Subject: [RFC PATCH 32/35] Add Xen driver utility functions.

Allocate/destroy a 'vmalloc' VM area: alloc_vm_area and free_vm_area
The alloc function ensures that page tables are constructed for the
region of kernel virtual address space and mapped into init_mm.

Lock an area so that PTEs are accessible in the current address space:
lock_vm_area and unlock_vm_area
The lock function prevents context switches to a lazy mm that doesn't
have the area mapped into its page tables. It also ensures that the
page tables are mapped into the current mm by causing the page fault
handler to copy the page directory pointers from init_mm into the
current mm.

Signed-off-by: Ian Pratt <[email protected]>
Signed-off-by: Christian Limpach <[email protected]>
Signed-off-by: Chris Wright <[email protected]>
Cc: "Jan Beulich" <[email protected]>
---
TODO:
- possible vmalloc_sync use instead

drivers/xen/Makefile | 2 +
drivers/xen/util.c | 70 ++++++++++++++++++++++++++++++++++++++++++++++
include/xen/driver_util.h | 16 ++++++++++
3 files changed, 88 insertions(+)

--- linus-2.6.orig/drivers/xen/Makefile
+++ linus-2.6/drivers/xen/Makefile
@@ -1,4 +1,6 @@

+obj-y += util.o
+
obj-y += core/
obj-y += console/

--- /dev/null
+++ linus-2.6/drivers/xen/util.c
@@ -0,0 +1,70 @@
+#include <linux/config.h>
+#include <linux/mm.h>
+#include <linux/module.h>
+#include <linux/slab.h>
+#include <linux/vmalloc.h>
+#include <asm/uaccess.h>
+#include <xen/driver_util.h>
+
+static int f(pte_t *pte, struct page *pmd_page, unsigned long addr, void *data)
+{
+ /* apply_to_page_range() does all the hard work. */
+ return 0;
+}
+
+struct vm_struct *alloc_vm_area(unsigned long size)
+{
+ struct vm_struct *area;
+
+ area = get_vm_area(size, VM_IOREMAP);
+ if (area == NULL)
+ return NULL;
+
+ /*
+ * This ensures that page tables are constructed for this region
+ * of kernel virtual address space and mapped into init_mm.
+ */
+ if (apply_to_page_range(&init_mm, (unsigned long)area->addr,
+ area->size, f, NULL)) {
+ free_vm_area(area);
+ return NULL;
+ }
+
+ return area;
+}
+EXPORT_SYMBOL_GPL(alloc_vm_area);
+
+void free_vm_area(struct vm_struct *area)
+{
+ struct vm_struct *ret;
+ ret = remove_vm_area(area->addr);
+ BUG_ON(ret != area);
+ kfree(area);
+}
+EXPORT_SYMBOL_GPL(free_vm_area);
+
+void lock_vm_area(struct vm_struct *area)
+{
+ unsigned long i;
+ char c;
+
+ /*
+ * Prevent context switch to a lazy mm that doesn't have this area
+ * mapped into its page tables.
+ */
+ preempt_disable();
+
+ /*
+ * Ensure that the page tables are mapped into the current mm. The
+ * page-fault path will copy the page directory pointers from init_mm.
+ */
+ for (i = 0; i < area->size; i += PAGE_SIZE)
+ (void)__get_user(c, (char __user *)area->addr + i);
+}
+EXPORT_SYMBOL_GPL(lock_vm_area);
+
+void unlock_vm_area(struct vm_struct *area)
+{
+ preempt_enable();
+}
+EXPORT_SYMBOL_GPL(unlock_vm_area);
--- /dev/null
+++ linus-2.6/include/xen/driver_util.h
@@ -0,0 +1,16 @@
+
+#ifndef __ASM_XEN_DRIVER_UTIL_H__
+#define __ASM_XEN_DRIVER_UTIL_H__
+
+#include <linux/config.h>
+#include <linux/vmalloc.h>
+
+/* Allocate/destroy a 'vmalloc' VM area. */
+extern struct vm_struct *alloc_vm_area(unsigned long size);
+extern void free_vm_area(struct vm_struct *area);
+
+/* Lock an area so that PTEs are accessible in the current address space. */
+extern void lock_vm_area(struct vm_struct *area);
+extern void unlock_vm_area(struct vm_struct *area);
+
+#endif /* __ASM_XEN_DRIVER_UTIL_H__ */

--


2006-05-09 19:49:40

by Greg KH

[permalink] [raw]
Subject: Re: [RFC PATCH 32/35] Add Xen driver utility functions.

On Tue, May 09, 2006 at 12:00:32AM -0700, Chris Wright wrote:
> +EXPORT_SYMBOL_GPL(alloc_vm_area);

> +EXPORT_SYMBOL_GPL(free_vm_area);

> +EXPORT_SYMBOL_GPL(lock_vm_area);

> +EXPORT_SYMBOL_GPL(unlock_vm_area);

These are all pretty generic function names. Perhaps they belong in the
core kernel code instead of a Xen specific file?

thanks,

greg k-h

2006-05-09 21:52:48

by Andi Kleen

[permalink] [raw]
Subject: Re: [RFC PATCH 32/35] Add Xen driver utility functions.

On Tuesday 09 May 2006 09:00, Chris Wright wrote:
> Allocate/destroy a 'vmalloc' VM area: alloc_vm_area and free_vm_area
> The alloc function ensures that page tables are constructed for the
> region of kernel virtual address space and mapped into init_mm.
>
> Lock an area so that PTEs are accessible in the current address space:
> lock_vm_area and unlock_vm_area
> The lock function prevents context switches to a lazy mm that doesn't
> have the area mapped into its page tables. It also ensures that the
> page tables are mapped into the current mm by causing the page fault
> handler to copy the page directory pointers from init_mm into the
> current mm.

Having that in drivers/xen looks wrong. It should be probably somewhere generic.

-Andi