2006-05-20 23:59:40

by Ameer Armaly

Subject: [patch] i386 warning cleanups that work

Here is a version that works, without the efi stuff that caused all the problems, and which I assumed after making the cpu and apm stuff work would work just as easily; just goes to show the
problems with lazyness.

diff --git a/arch/i386/kernel/apm.c b/arch/i386/kernel/apm.c
index df0e174..fc34cf2 100644
--- a/arch/i386/kernel/apm.c
+++ b/arch/i386/kernel/apm.c
@@ -1063,7 +1063,7 @@ #if defined(CONFIG_APM_DISPLAY_BLANK) &&

static int apm_console_blank(int blank)
{
- int error, i;
+ int error = 0, i;
u_short state;
static const u_short dev[3] = { 0x100, 0x1FF, 0x101 };

@@ -1282,7 +1282,7 @@ static void standby(void)
static apm_event_t get_event(void)
{
int error;
- apm_event_t event;
+ apm_event_t event = 0;
apm_eventinfo_t info;

static int notified;
diff --git a/arch/i386/kernel/cpu/transmeta.c b/arch/i386/kernel/cpu/transmeta.c
index 7214c9b..0737890 100644
--- a/arch/i386/kernel/cpu/transmeta.c
+++ b/arch/i386/kernel/cpu/transmeta.c
@@ -9,7 +9,7 @@ static void __init init_transmeta(struct
{
unsigned int cap_mask, uk, max, dummy;
unsigned int cms_rev1, cms_rev2;
- unsigned int cpu_rev, cpu_freq, cpu_flags, new_cpu_rev;
+ unsigned int cpu_rev, cpu_freq = 0, cpu_flags, new_cpu_rev;
char cpu_info[65];

get_model_name(c); /* Same as AMD/Cyrix */

2006-05-21 00:12:21

by Dave Jones

Subject: Re: [patch] i386 warning cleanups that work

On Sat, May 20, 2006 at 07:59:17PM -0400, Ameer Armaly wrote:

> diff --git a/arch/i386/kernel/cpu/transmeta.c
> b/arch/i386/kernel/cpu/transmeta.c
> index 7214c9b..0737890 100644
> --- a/arch/i386/kernel/cpu/transmeta.c
> +++ b/arch/i386/kernel/cpu/transmeta.c
> @@ -9,7 +9,7 @@ static void __init init_transmeta(struct
> {
> unsigned int cap_mask, uk, max, dummy;
> unsigned int cms_rev1, cms_rev2;
> - unsigned int cpu_rev, cpu_freq, cpu_flags, new_cpu_rev;
> + unsigned int cpu_rev, cpu_freq = 0, cpu_flags, new_cpu_rev;
> char cpu_info[65];
>
> get_model_name(c); /* Same as AMD/Cyrix */

http://www.gossamer-threads.com/lists/linux/kernel/647975?page=last

Dave

--
http://www.codemonkey.org.uk