2006-05-24 18:31:51

by Pete Zaitcev

[permalink] [raw]
Subject: Patch for atkbd.c from Ubuntu

Hi, Dmitry:

What do you think about the attached? Apparently, this is needed to
support Korean input keys. Please let me know if this can be included.

Here's a bug entry for reference:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192637

Yours,
-- Pete

diff -ruN linux-2.6.16.i686.orig/drivers/input/keyboard/atkbd.c linux-2.6.16.i686/drivers/input/keyboard/atkbd.c
--- linux-2.6.16.i686.orig/drivers/input/keyboard/atkbd.c 2006-05-23 18:16:01.000000000 +0900
+++ linux-2.6.16.i686/drivers/input/keyboard/atkbd.c 2006-05-24 12:46:09.000000000 +0900
@@ -85,7 +85,7 @@
0, 56, 42, 93, 29, 16, 2, 0, 0, 0, 44, 31, 30, 17, 3, 0,
0, 46, 45, 32, 18, 5, 4, 95, 0, 57, 47, 33, 20, 19, 6,183,
0, 49, 48, 35, 34, 21, 7,184, 0, 0, 50, 36, 22, 8, 9,185,
- 0, 51, 37, 23, 24, 11, 10, 0, 0, 52, 53, 38, 39, 25, 12, 0,
+ 0, 51, 37, 23, 24, 11, 10,122,123, 52, 53, 38, 39, 25, 12, 0,
0, 89, 40, 0, 26, 13, 0, 0, 58, 54, 28, 27, 0, 43, 0, 85,
0, 86, 91, 90, 92, 0, 14, 94, 0, 79,124, 75, 71,121, 0, 0,
82, 83, 80, 76, 77, 72, 1, 69, 87, 78, 81, 74, 55, 73, 70, 99,

-- Pete


2006-05-29 04:59:36

by Dmitry Torokhov

[permalink] [raw]
Subject: Re: Patch for atkbd.c from Ubuntu

On Wednesday 24 May 2006 14:31, Pete Zaitcev wrote:
> Hi, Dmitry:
>
> What do you think about the attached? Apparently, this is needed to
> support Korean input keys. Please let me know if this can be included.
>
> Here's a bug entry for reference:
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=192637
>

Hi Pete,

Please look here:

http://bugzilla.kernel.org/show_bug.cgi?id=2817#c4

"I will not accept this patch (or any similar patch) to extend the atkbd.c
mapping table - only standard scancodes are allowed there. The table is
easily modified from userspace, and that is the way to go.

In the past I tried to fill the table with all the entries, but found out
that there are two or three keyboards competing for every position in the
scancode table, with a different keycode."

I continue to agree with Vojtech's position here. Because kernel does not
have ability to detect the kind of keyboard connected to a box (nor do we
really want to store all this data in the kernel) all fine tuning of AT
keymap should be done from userspace.

--
Dmitry

2006-05-29 06:34:34

by Pete Zaitcev

[permalink] [raw]
Subject: Re: Patch for atkbd.c from Ubuntu

On Mon, 29 May 2006 00:59:31 -0400, Dmitry Torokhov <[email protected]> wrote:

> http://bugzilla.kernel.org/show_bug.cgi?id=2817#c4

Thanks for letting me know, especially the reference.

-- Pete