2006-05-29 17:49:09

by Nick Warne

[permalink] [raw]
Subject: Question on Space.c

I saw Space.o being build, and seeing as it is Capitalised thought I would see
why, and maybe a patch to make it all lower case.

The patch is trivial:

--- drivers/net/MakefileOrig 2006-05-29 17:59:09.000000000 +0100
+++ drivers/net/Makefile 2006-05-29 17:59:23.000000000 +0100
@@ -79,7 +79,7 @@

obj-$(CONFIG_SUNDANCE) += sundance.o
obj-$(CONFIG_HAMACHI) += hamachi.o
-obj-$(CONFIG_NET) += Space.o loopback.o
+obj-$(CONFIG_NET) += space.o loopback.o
obj-$(CONFIG_SEEQ8005) += seeq8005.o
obj-$(CONFIG_NET_SB1000) += sb1000.o
obj-$(CONFIG_MAC8390) += mac8390.o 8390.o

then/and rename drivers/net/Space.c -> drivers/net/space.c

It all builds OK (not booted with it though).

Doing a grep of source after changes reveals only a few documentation/comments
refer to Space.c - no other code.

I have looked though docs and googled as to why this One File Is Like This to
no avail? Convention?

Nick
--
"Person who say it cannot be done should not interrupt person doing it."
-Chinese Proverb


2006-05-29 18:06:13

by Brian F. G. Bidulock

[permalink] [raw]
Subject: Re: Question on Space.c

Nick,

On Mon, 29 May 2006, Nick Warne wrote:

> I saw Space.o being build, and seeing as it is Capitalised thought I would see
> why, and maybe a patch to make it all lower case.
...
...
> I have looked though docs and googled as to why this One File Is Like This to
> no avail? Convention?
>

Yes, convention: SVR4 had a Space.c file for defining drivers.

--brian

2006-05-29 18:05:30

by Jesper Juhl

[permalink] [raw]
Subject: Re: Question on Space.c

On 29/05/06, Nick Warne <[email protected]> wrote:
> I saw Space.o being build, and seeing as it is Capitalised thought I would see
> why, and maybe a patch to make it all lower case.
>
[snip]
> I have looked though docs and googled as to why this One File Is Like This to
> no avail? Convention?
>

The normal convention is for filenames to be all lowercase except for
some special ones like "Makefile", "Kconfig", "README" etc (although
there are a few exceptions,for source files, like
drivers/scsi/NCR5380.c, include/asm-m68knommu/MC68328.h,
drivers/block/DAC960.c and others).
To find some more, try this in the kernel source dir : find ./ -name "[A-Z]*"

It would make sense to me personally to rename this one, but it's not
my call and besides it'll open a whole can of worms about whether or
not to rename the other ones...

--
Jesper Juhl <[email protected]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html

2006-05-29 18:11:31

by Nick Warne

[permalink] [raw]
Subject: Re: Question on Space.c

On Monday 29 May 2006 19:05, Jesper Juhl wrote:
> On 29/05/06, Nick Warne <[email protected]> wrote:
> > I saw Space.o being build, and seeing as it is Capitalised thought I
> > would see why, and maybe a patch to make it all lower case.
>
> [snip]
>
> > I have looked though docs and googled as to why this One File Is Like
> > This to no avail? Convention?
>
> The normal convention is for filenames to be all lowercase except for
> some special ones like "Makefile", "Kconfig", "README" etc (although
> there are a few exceptions,for source files, like
> drivers/scsi/NCR5380.c, include/asm-m68knommu/MC68328.h,
> drivers/block/DAC960.c and others).
> To find some more, try this in the kernel source dir : find ./ -name
> "[A-Z]*"
>
> It would make sense to me personally to rename this one, but it's not
> my call and besides it'll open a whole can of worms about whether or
> not to rename the other ones...

Well, I don't think so. Apart from the really conventional file names
(Makefile et al), the others you mentioned are abbreviations*, so it is
obvious. Now Ncr5380.c would be a different kettle of fish...

Nick
* abbreviation: a long word used to describe a short word used in place of a
long word.
--
"Person who say it cannot be done should not interrupt person doing it."
-Chinese Proverb

2006-05-29 19:03:32

by Al Viro

[permalink] [raw]
Subject: Re: Question on Space.c

On Mon, May 29, 2006 at 07:11:25PM +0100, Nick Warne wrote:
> > drivers/scsi/NCR5380.c, include/asm-m68knommu/MC68328.h,
> > drivers/block/DAC960.c and others).
> > To find some more, try this in the kernel source dir : find ./ -name
> > "[A-Z]*"
> >
> > It would make sense to me personally to rename this one, but it's not
> > my call and besides it'll open a whole can of worms about whether or
> > not to rename the other ones...
>
> Well, I don't think so. Apart from the really conventional file names
> (Makefile et al), the others you mentioned are abbreviations*, so it is
> obvious. Now Ncr5380.c would be a different kettle of fish...
>
> Nick
> * abbreviation: a long word used to describe a short word used in place of a
> long word.

Right... Now look for definition of acronym somewhere...