2006-05-07 02:02:55

by Jesper Juhl

Subject: [PATCH] fix mem-leak in sidewinder driver

In sw_connect we leak 'buf' and 'idbuf' when we do not leave via one of
the fail* labels. This was spotted by the coverity checker.
This patch fixes the memory leak.

Patch is compile tested only due to lack of hardware.


Signed-off-by: Jesper Juhl <[email protected]>
---

drivers/input/joystick/sidewinder.c | 2 ++
1 files changed, 2 insertions(+)

--- linux-2.6.17-rc3-git12-orig/drivers/input/joystick/sidewinder.c 2006-03-20 06:53:29.000000000 +0100
+++ linux-2.6.17-rc3-git12/drivers/input/joystick/sidewinder.c 2006-05-07 03:57:47.000000000 +0200
@@ -776,6 +776,8 @@ static int sw_connect(struct gameport *g
goto fail4;
}

+ kfree(buf);
+ kfree(idbuf);
return 0;

fail4: input_free_device(sw->dev[i]);

2006-05-30 03:49:04

by Dmitry Torokhov

Subject: Re: [PATCH] fix mem-leak in sidewinder driver

On Saturday 06 May 2006 22:03, Jesper Juhl wrote:
> In sw_connect we leak 'buf' and 'idbuf' when we do not leave via one of
> the fail* labels. This was spotted by the coverity checker.
> This patch fixes the memory leak.
>

Applied, thank you Jesper.

--
Dmitry