2006-05-30 20:17:43

by Alexey Dobriyan

Subject: [PATCH] blktrace_api.h: endian annotations

Signed-off-by: Alexey Dobriyan <[email protected]>
---

include/linux/blktrace_api.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

--- a/include/linux/blktrace_api.h
+++ b/include/linux/blktrace_api.h
@@ -89,13 +89,13 @@ struct blk_io_trace {

/*
* The remap event
*/
struct blk_io_trace_remap {
- u32 device;
+ __be32 device;
u32 __pad;
- u64 sector;
+ __be64 sector;
};

enum {
Blktrace_setup = 1,
Blktrace_running,
@@ -223,11 +223,11 @@ static inline void blk_add_trace_generic
**/
static inline void blk_add_trace_pdu_int(struct request_queue *q, u32 what,
struct bio *bio, unsigned int pdu)
{
struct blk_trace *bt = q->blk_trace;
- u64 rpdu = cpu_to_be64(pdu);
+ __be64 rpdu = cpu_to_be64(pdu);

if (likely(!bt))
return;

if (bio)

2006-05-31 06:15:32

by Jens Axboe

Subject: Re: [PATCH] blktrace_api.h: endian annotations

On Wed, May 31 2006, Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <[email protected]>

It's fine I suppose, though it doesn't add much in the way of checking.
These are the ends of the chain, it's not structures we pass around.

--
Jens Axboe