On Mon, 31 Jul 2006 10:28:14 +0200
Edgar Hucek <[email protected]> wrote:
> This Patch add force for mmconfig. On Intel Macs the efi firmaware gives
> a different memory map then ACPI_MCFG provides. This makes the check wether
> to use mmconfig or not fail.
Sorry, you cannot do this. I already merged this patch into -mm, and
followed that up with two bugfix patches, both of which you were copied on.
Now you're sending out the original patch, without the bugfixes which
Adrian and I prepared.
If you think these patches should be merged into 2.6.18 at this late a
stage, please give reasons and if they're agreeable I can send it all to
Linus. But sending out known-buggy stuff which has already been fixed
doesn't help anyone.
Also, please don't use filenames as patch descriptions. See section 2 of
http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt.
Thanks.
Andrew Morton schrieb:
> On Mon, 31 Jul 2006 10:28:14 +0200
> Edgar Hucek <[email protected]> wrote:
>
>> This Patch add force for mmconfig. On Intel Macs the efi firmaware gives
>> a different memory map then ACPI_MCFG provides. This makes the check wether
>> to use mmconfig or not fail.
>
> Sorry, you cannot do this. I already merged this patch into -mm, and
> followed that up with two bugfix patches, both of which you were copied on.
>
> Now you're sending out the original patch, without the bugfixes which
> Adrian and I prepared.
>
> If you think these patches should be merged into 2.6.18 at this late a
> stage, please give reasons and if they're agreeable I can send it all to
> Linus. But sending out known-buggy stuff which has already been fixed
> doesn't help anyone.
>
> Also, please don't use filenames as patch descriptions. See section 2 of
> http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt.
>
> Thanks.
>
I see only one bugfix patch in your patches ( add-force-of-use-mmconfig-fix.patch )
which is now included in this patch.
cu
ED.
On Tue, 01 Aug 2006 07:26:15 +0200
Edgar Hucek <[email protected]> wrote:
> Andrew Morton schrieb:
> > On Mon, 31 Jul 2006 10:28:14 +0200
> > Edgar Hucek <[email protected]> wrote:
> >
> >> This Patch add force for mmconfig. On Intel Macs the efi firmaware gives
> >> a different memory map then ACPI_MCFG provides. This makes the check wether
> >> to use mmconfig or not fail.
> >
> > Sorry, you cannot do this. I already merged this patch into -mm, and
> > followed that up with two bugfix patches, both of which you were copied on.
> >
> > Now you're sending out the original patch, without the bugfixes which
> > Adrian and I prepared.
> >
> > If you think these patches should be merged into 2.6.18 at this late a
> > stage, please give reasons and if they're agreeable I can send it all to
> > Linus. But sending out known-buggy stuff which has already been fixed
> > doesn't help anyone.
> >
> > Also, please don't use filenames as patch descriptions. See section 2 of
> > http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt.
> >
> > Thanks.
> >
>
> I see only one bugfix patch in your patches ( add-force-of-use-mmconfig-fix.patch )
> which is now included in this patch.
>
I presently have
add-force-of-use-mmconfig.patch
add-force-of-use-mmconfig-fix.patch
add-force-of-use-mmconfig-fix-2.patch
and
add-efi-e820-memory-mapping-on-x86.patch
add-efi-e820-memory-mapping-on-x86-tidy.patch
add-efi-e820-memory-mapping-on-x86-fix.patch
add-efi-e820-memory-mapping-on-x86-fix-2.patch
all of which you should have been cc'ed on.
Anyway, unless there's a rush on this work, please check that everything
looks OK in -mm as we head into 2.6.19-rc1.
Andrew Morton schrieb:
> On Tue, 01 Aug 2006 07:26:15 +0200
> Edgar Hucek <[email protected]> wrote:
>
>> Andrew Morton schrieb:
>>> On Mon, 31 Jul 2006 10:28:14 +0200
>>> Edgar Hucek <[email protected]> wrote:
>>>
>>>> This Patch add force for mmconfig. On Intel Macs the efi firmaware gives
>>>> a different memory map then ACPI_MCFG provides. This makes the check wether
>>>> to use mmconfig or not fail.
>>> Sorry, you cannot do this. I already merged this patch into -mm, and
>>> followed that up with two bugfix patches, both of which you were copied on.
>>>
>>> Now you're sending out the original patch, without the bugfixes which
>>> Adrian and I prepared.
>>>
>>> If you think these patches should be merged into 2.6.18 at this late a
>>> stage, please give reasons and if they're agreeable I can send it all to
>>> Linus. But sending out known-buggy stuff which has already been fixed
>>> doesn't help anyone.
>>>
>>> Also, please don't use filenames as patch descriptions. See section 2 of
>>> http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt.
>>>
>>> Thanks.
>>>
>> I see only one bugfix patch in your patches ( add-force-of-use-mmconfig-fix.patch )
>> which is now included in this patch.
>>
>
> I presently have
>
> add-force-of-use-mmconfig.patch
> add-force-of-use-mmconfig-fix.patch
> add-force-of-use-mmconfig-fix-2.patch
>
> and
>
> add-efi-e820-memory-mapping-on-x86.patch
> add-efi-e820-memory-mapping-on-x86-tidy.patch
> add-efi-e820-memory-mapping-on-x86-fix.patch
> add-efi-e820-memory-mapping-on-x86-fix-2.patch
>
> all of which you should have been cc'ed on.
>
> Anyway, unless there's a rush on this work, please check that everything
> looks OK in -mm as we head into 2.6.19-rc1.
>
Mea culpa. Looked at the wrong place. I checked the patches in mm and they look ok.
cu
Edgar Hucek