2006-08-01 18:38:29

by Dave Jones

[permalink] [raw]
Subject: runtime disable for softlockup

The softlockup detector is damned handy, but a real pain if it
prevents your distro installer from running.
As a 'worse case scenario', with the diff below, users can
disable it at boot time, and still manage to get a box installed.

Signed-off-by: Dave Jones <[email protected]>

--- linux-2.6/init/main.c~ 2006-03-05 00:45:51.000000000 -0500
+++ linux-2.6/init/main.c 2006-03-05 00:49:41.000000000 -0500
@@ -640,6 +640,15 @@ static void __init do_basic_setup(void)
do_initcalls();
}

+static int __initdata nosoftlockup;
+
+static int __init nosoftlockup_setup(char *str)
+{
+ nosoftlockup = 1;
+ return 1;
+}
+__setup("nosoftlockup", nosoftlockup_setup);
+
static void do_pre_smp_initcalls(void)
{
extern int spawn_ksoftirqd(void);
@@ -649,7 +657,8 @@ static void do_pre_smp_initcalls(void)
migration_init();
#endif
spawn_ksoftirqd();
- spawn_softlockup_task();
+ if (!nosoftlockup)
+ spawn_softlockup_task();
}

static void run_init_process(char *init_filename)

--
http://www.codemonkey.org.uk


2006-08-04 07:48:17

by Andrew Morton

[permalink] [raw]
Subject: Re: runtime disable for softlockup

On Tue, 1 Aug 2006 14:38:26 -0400
Dave Jones <[email protected]> wrote:

> The softlockup detector is damned handy, but a real pain if it
> prevents your distro installer from running.

Why is it triggering??

2006-08-04 17:01:14

by Dave Jones

[permalink] [raw]
Subject: Re: runtime disable for softlockup

On Fri, Aug 04, 2006 at 12:48:02AM -0700, Andrew Morton wrote:
> On Tue, 1 Aug 2006 14:38:26 -0400
> Dave Jones <[email protected]> wrote:
>
> > The softlockup detector is damned handy, but a real pain if it
> > prevents your distro installer from running.
>
> Why is it triggering??

It blew up in a few cases circa FC4, which prevented installs, which
led me to do this 'just in case' for FC5. The actual lockups got
fixed up somewhere in between, but this is still a nice safety net.

Dave

--
http://www.codemonkey.org.uk