2006-08-02 03:55:59

by Shawn Starr

[permalink] [raw]
Subject: Re: [2.6.18-rc2][e1000][swsusp] - Regression - Suspend to disk and resume breaks e1000 - RESOLVED Bug #6867

On Sunday 16 July 2006 12:33 pm, Auke Kok wrote:
> [adding netdev to the cc]
>
> unfortunately I didn't.
>
> e1000 has a special e1000_pci_save_state/e1000_pci_restore_state set of
> routines that save and restore the configuration space. the fact that it
> works for suspend to memory to me suggests that there is nothing wrong with
> that.
>
> I'm surprised that the t42 comes with a PCI/PCI-X e1000, which changes the
> need for this special routine, and the routine does the exact same thing as
> pci_save_state in your case. These special routines are made to handle
> PCI-E cards properly.
>
> Also there are no config_pm changes related to this in 2.6.18-rc2. Most of
> this code has been in the kernel for a few major releases afaik. This code
> worked fine before, so I don't rule out any suspend-related issues. You
> should certainly compare with 2.6.18-rc1 and make sure it was a regression,
> perhaps even bisect the e1000-related changes if you have the time, which
> is about 22 patches or so.
>
> I'll see if I can find out some more once I get back to work.
>
> Auke

Hi Auke,

It appears 2.6.18-rc3 this does not occur anymore. I suspended to disk/ram and
the interface pci registers were restored. Bugzilla #6867

Thanks,

Shawn.




2006-08-02 15:08:01

by Kok, Auke

[permalink] [raw]
Subject: Re: [2.6.18-rc2][e1000][swsusp] - Regression - Suspend to disk and resume breaks e1000 - RESOLVED Bug #6867

Shawn Starr wrote:
> On Sunday 16 July 2006 12:33 pm, Auke Kok wrote:
>> [adding netdev to the cc]
>>
>> unfortunately I didn't.
>>
>> e1000 has a special e1000_pci_save_state/e1000_pci_restore_state set of
>> routines that save and restore the configuration space. the fact that it
>> works for suspend to memory to me suggests that there is nothing wrong with
>> that.

> Hi Auke,
>
> It appears 2.6.18-rc3 this does not occur anymore. I suspended to disk/ram and
> the interface pci registers were restored. Bugzilla #6867

I would not be surprised if all the suspend issues in 2.6.18rcX were not
involved in this somehow... thanks for reporting back in.

Auke