2006-08-06 23:39:58

by Pierre Ossman

Subject: [PATCH] [MMC] Another stray 'io' reference

Another misuse of the global 'io' variable instead of the local 'base'.

Signed-off-by: Pierre Ossman <[email protected]>
---

drivers/mmc/wbsd.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/wbsd.c b/drivers/mmc/wbsd.c
index ce86887..c351c6d 100644
--- a/drivers/mmc/wbsd.c
+++ b/drivers/mmc/wbsd.c
@@ -1773,7 +1773,7 @@ static int __devinit wbsd_init(struct de
/*
* Request resources.
*/
- ret = wbsd_request_resources(host, io, irq, dma);
+ ret = wbsd_request_resources(host, base, irq, dma);
if (ret) {
wbsd_release_resources(host);
wbsd_free_mmc(dev);
@@ -1861,6 +1861,7 @@ static void __devexit wbsd_shutdown(stru

static int __devinit wbsd_probe(struct platform_device *dev)
{
+ /* Use the module parameters for resources */
return wbsd_init(&dev->dev, io, irq, dma, 0);
}

2006-08-06 23:41:41

by Pierre Ossman

Subject: Re: [PATCH] [MMC] Another stray 'io' reference

Pierre Ossman wrote:
> Another misuse of the global 'io' variable instead of the local 'base'.
>
> Signed-off-by: Pierre Ossman <[email protected]>
> ---
>

This should be it. I did a search for 'io' in the entire driver and
found no other incorrect uses.

2006-08-07 13:48:36

by Russell King

Subject: Re: [PATCH] [MMC] Another stray 'io' reference

On Mon, Aug 07, 2006 at 01:40:04AM +0200, Pierre Ossman wrote:
> Another misuse of the global 'io' variable instead of the local 'base'.

Applied, thanks.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core