2006-08-14 07:02:29

by Rolf Eike Beer

Subject: [PATCH][BUILD] Fix "mkdir -p" usage in scripts/package/mkspec

"mkdir -p" does not only mean not to complain if the directory already
exists, but also to create the parent directories if needed. This patch
removes "lib" from the list of directories to create as we will also create
"lib/modules".

Signed-off-by: Rolf Eike Beer <[email protected]>

---
commit 288a3f1fd00365669ed9ad725b15ff67004cee0a
tree 5352b0426d399ac9f0a0f795c7dab1c487c63e82
parent cc4a7b5dfee25083a6a5741b5b640ae2a1d3aa12
author Rolf Eike Beer <[email protected]> Mon, 14 Aug 2006 08:12:56 +0200
committer Rolf Eike Beer <[email protected]> Mon, 14 Aug 2006 08:12:56 +0200

scripts/package/mkspec | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/package/mkspec b/scripts/package/mkspec
index df89284..ffd61fe 100755
--- a/scripts/package/mkspec
+++ b/scripts/package/mkspec
@@ -63,9 +63,9 @@ fi

echo "%install"
echo "%ifarch ia64"
-echo 'mkdir -p $RPM_BUILD_ROOT/boot/efi $RPM_BUILD_ROOT/lib $RPM_BUILD_ROOT/lib/modules'
+echo 'mkdir -p $RPM_BUILD_ROOT/boot/efi $RPM_BUILD_ROOT/lib/modules'
echo "%else"
-echo 'mkdir -p $RPM_BUILD_ROOT/boot $RPM_BUILD_ROOT/lib $RPM_BUILD_ROOT/lib/modules'
+echo 'mkdir -p $RPM_BUILD_ROOT/boot $RPM_BUILD_ROOT/lib/modules'
echo "%endif"

echo 'INSTALL_MOD_PATH=$RPM_BUILD_ROOT make %{_smp_mflags} modules_install'

2006-09-24 08:51:53

by Sam Ravnborg

Subject: Re: [PATCH][BUILD] Fix "mkdir -p" usage in scripts/package/mkspec

On Mon, Aug 14, 2006 at 08:16:47AM +0200, Rolf Eike Beer wrote:
> "mkdir -p" does not only mean not to complain if the directory already
> exists, but also to create the parent directories if needed. This patch
> removes "lib" from the list of directories to create as we will also create
> "lib/modules".

Applied,

Sam