2006-08-10 19:37:08

by Andi Kleen

Subject: [PATCH for review] [102/145] x86_64: Remove unneeded externs in acpi/boot.c

r

And move one into proto.h

Cc: [email protected]
Signed-off-by: Andi Kleen <[email protected]>

---
arch/i386/kernel/acpi/boot.c | 3 ---
include/asm-x86_64/proto.h | 2 ++
2 files changed, 2 insertions(+), 3 deletions(-)

Index: linux/arch/i386/kernel/acpi/boot.c
===================================================================
--- linux.orig/arch/i386/kernel/acpi/boot.c
+++ linux/arch/i386/kernel/acpi/boot.c
@@ -47,9 +47,6 @@ EXPORT_SYMBOL(acpi_disabled);

#ifdef CONFIG_X86_64

-extern void __init clustered_apic_check(void);
-
-extern int gsi_irq_sharing(int gsi);
#include <asm/proto.h>

static inline int acpi_madt_oem_check(char *oem_id, char *oem_table_id) { return 0; }
Index: linux/include/asm-x86_64/proto.h
===================================================================
--- linux.orig/include/asm-x86_64/proto.h
+++ linux/include/asm-x86_64/proto.h
@@ -124,6 +124,8 @@ extern int fix_aperture;
extern int reboot_force;
extern int notsc_setup(char *);

+extern int gsi_irq_sharing(int gsi);
+
extern void smp_local_timer_interrupt(struct pt_regs * regs);

long do_arch_prctl(struct task_struct *task, int code, unsigned long addr);

2006-08-16 15:39:39

by Brown, Len

Subject: Re: [PATCH for review] [102/145] x86_64: Remove unneeded externs in acpi/boot.c

On Thursday 10 August 2006 15:37, Andi Kleen wrote:

> And move one into proto.h
>
> Cc: [email protected]

Acked-by: Len Brown <[email protected]>

> Signed-off-by: Andi Kleen <[email protected]>
>
> ---
> arch/i386/kernel/acpi/boot.c | 3 ---
> include/asm-x86_64/proto.h | 2 ++
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> Index: linux/arch/i386/kernel/acpi/boot.c
> ===================================================================
> --- linux.orig/arch/i386/kernel/acpi/boot.c
> +++ linux/arch/i386/kernel/acpi/boot.c
> @@ -47,9 +47,6 @@ EXPORT_SYMBOL(acpi_disabled);
>
> #ifdef CONFIG_X86_64
>
> -extern void __init clustered_apic_check(void);
> -
> -extern int gsi_irq_sharing(int gsi);
> #include <asm/proto.h>
>
> static inline int acpi_madt_oem_check(char *oem_id, char *oem_table_id) { return 0; }
> Index: linux/include/asm-x86_64/proto.h
> ===================================================================
> --- linux.orig/include/asm-x86_64/proto.h
> +++ linux/include/asm-x86_64/proto.h
> @@ -124,6 +124,8 @@ extern int fix_aperture;
> extern int reboot_force;
> extern int notsc_setup(char *);
>
> +extern int gsi_irq_sharing(int gsi);
> +
> extern void smp_local_timer_interrupt(struct pt_regs * regs);
>
> long do_arch_prctl(struct task_struct *task, int code, unsigned long addr);