2006-08-16 22:17:24

by Josh Triplett

Subject: [PATCH] rcu: Fix incorrect description of default for rcutorture nreaders parameter

The comment for the nreaders parameter of rcutorture gives the default as
4*ncpus, but the value actually defaults to 2*ncpus; fix the comment.

Signed-off-by: Josh Triplett <[email protected]>
---
kernel/rcutorture.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c
index 0778a3d..e34d22b 100644
--- a/kernel/rcutorture.c
+++ b/kernel/rcutorture.c
@@ -48,7 +48,7 @@ #include <linux/srcu.h>

MODULE_LICENSE("GPL");

-static int nreaders = -1; /* # reader threads, defaults to 4*ncpus */
+static int nreaders = -1; /* # reader threads, defaults to 2*ncpus */
static int stat_interval; /* Interval between stats, in seconds. */
/* Defaults to "only at end of test". */
static int verbose; /* Print more debug info. */
--
1.4.1.1

2006-08-16 23:35:05

by Paul E. McKenney

Subject: Re: [PATCH] rcu: Fix incorrect description of default for rcutorture nreaders parameter

On Wed, Aug 16, 2006 at 03:17:04PM -0700, Josh Triplett wrote:
> The comment for the nreaders parameter of rcutorture gives the default as
> 4*ncpus, but the value actually defaults to 2*ncpus; fix the comment.


Acked-by: Paul E. McKenney <[email protected]>
> Signed-off-by: Josh Triplett <[email protected]>
> ---
> kernel/rcutorture.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c
> index 0778a3d..e34d22b 100644
> --- a/kernel/rcutorture.c
> +++ b/kernel/rcutorture.c
> @@ -48,7 +48,7 @@ #include <linux/srcu.h>
>
> MODULE_LICENSE("GPL");
>
> -static int nreaders = -1; /* # reader threads, defaults to 4*ncpus */
> +static int nreaders = -1; /* # reader threads, defaults to 2*ncpus */
> static int stat_interval; /* Interval between stats, in seconds. */
> /* Defaults to "only at end of test". */
> static int verbose; /* Print more debug info. */
> --
> 1.4.1.1
>
>