2006-08-26 15:06:57

by Adrian Bunk

Subject: [2.6 patch] fs/xfs/xfs_bmap.c:xfs_bmapi(): fix a bug

This patch fixes the following bug introduced by commit
39269e29d4aad04252e0debec4c9b01bac16a257:

Since bma.conv is a char and XFS_BMAPI_CONVERT is 0x1000, bma.conv was
always assigned zero.

Spotted by the GNU C compiler (SVN version).

Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.18-rc4-mm2/fs/xfs/xfs_bmap.c.old 2006-08-26 03:31:23.000000000 +0200
+++ linux-2.6.18-rc4-mm2/fs/xfs/xfs_bmap.c 2006-08-26 03:31:28.000000000 +0200
@@ -4993,7 +4993,7 @@ xfs_bmapi(
bma.firstblock = *firstblock;
bma.alen = alen;
bma.off = aoff;
- bma.conv = (flags & XFS_BMAPI_CONVERT);
+ bma.conv = !!(flags & XFS_BMAPI_CONVERT);
bma.wasdel = wasdelay;
bma.minlen = minlen;
bma.low = flist->xbf_low;

2006-08-28 00:31:52

by Nathan Scott

Subject: Re: [2.6 patch] fs/xfs/xfs_bmap.c:xfs_bmapi(): fix a bug

On Sat, Aug 26, 2006 at 05:06:55PM +0200, Adrian Bunk wrote:
> ...
> Since bma.conv is a char and XFS_BMAPI_CONVERT is 0x1000, bma.conv was
> always assigned zero.

Yep, looks good, thanks Adrian.

cheers.

--
Nathan