2006-08-31 09:54:00

by Akinobu Mita

Subject: [PATCH] rate limiting for the ldisc open faulure messages

This patch limits the messages when ldisc open faulures happen.
It happens under memory pressure.

Signed-off-by: Akinobu Mita <[email protected]>

drivers/char/tty_io.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

Index: work-shouldfail/drivers/char/tty_io.c
===================================================================
--- work-shouldfail.orig/drivers/char/tty_io.c
+++ work-shouldfail/drivers/char/tty_io.c
@@ -2072,8 +2072,9 @@ fail_no_mem:

/* call the tty release_mem routine to clean out this slot */
release_mem_out:
- printk(KERN_INFO "init_dev: ldisc open failed, "
- "clearing slot %d\n", idx);
+ if (printk_ratelimit())
+ printk(KERN_INFO "init_dev: ldisc open failed, "
+ "clearing slot %d\n", idx);
release_mem(tty, idx);
goto end_init;
}

2006-08-31 10:10:12

by Alan

Subject: Re: [PATCH] rate limiting for the ldisc open faulure messages

Ar Iau, 2006-08-31 am 18:49 +0900, ysgrifennodd Akinobu Mita:
> This patch limits the messages when ldisc open faulures happen.
> It happens under memory pressure.
>
> Signed-off-by: Akinobu Mita <[email protected]>

Acked-by: Alan Cox <[email protected]>


I'm suprised it ever occurs but the memory pressure case should indeed
be rate limited. Thanks