2006-08-31 12:32:53

by Pavel Machek

Subject: kernel/stop_machine.c: whose code is it?

Would kernel/stop_machine.c author please step up?

Signed-off-by: Pavel Machek <[email protected]>

(but I guess it would be better if author added signature to his work)

diff --git a/kernel/stop_machine.c b/kernel/stop_machine.c
index 51cacd1..ec0592c 100644
--- a/kernel/stop_machine.c
+++ b/kernel/stop_machine.c
@@ -1,3 +1,9 @@
+/*
+ * Copyright A.N.Onymous
+ *
+ * GPLv2
+ */
+
#include <linux/stop_machine.h>
#include <linux/kthread.h>
#include <linux/sched.h>
@@ -132,8 +138,7 @@ static void restart_machine(void)
preempt_enable_no_resched();
}

-struct stop_machine_data
-{
+struct stop_machine_data {
int (*fn)(void *);
void *data;
struct completion done;

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

2006-08-31 13:17:52

by Jiri Kosina

Subject: Re: kernel/stop_machine.c: whose code is it?

On Thu, 31 Aug 2006, Pavel Machek wrote:

> Would kernel/stop_machine.c author please step up?

IMHO it's Rusty Russell (added to CC).

--
JiKos.

2006-09-03 02:06:12

by Rusty Russell

Subject: Re: kernel/stop_machine.c: whose code is it?

On Thu, 2006-08-31 at 15:17 +0200, Jiri Kosina wrote:
> On Thu, 31 Aug 2006, Pavel Machek wrote:
>
> > Would kernel/stop_machine.c author please step up?
>
> IMHO it's Rusty Russell (added to CC).

Yep. Not sure the obsession with copyright on every trivial piece of
code is healthy, but if it keeps you happy (I had to look back: this
code was extracted from the module.c code in 2005).

Signed-off-by: Rusty Russell <[email protected]>
diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/dontdiff --minimal linux-2.6.18-rc5-git4/kernel/stop_machine.c tmp/kernel/stop_machine.c
--- linux-2.6.18-rc5-git4/kernel/stop_machine.c 2006-09-01 09:49:11.000000000 +1000
+++ tmp/kernel/stop_machine.c 2006-09-03 11:55:08.000000000 +1000
@@ -1,3 +1,6 @@
+/* Copyright 2005 Rusty Russell [email protected] IBM Corporation.
+ * GPL v2 and any later version.
+ */
#include <linux/stop_machine.h>
#include <linux/kthread.h>
#include <linux/sched.h>

--
Help! Save Australia from the worst of the DMCA: http://linux.org.au/law


--
VGER BF report: U 0.5

2006-09-03 06:34:15

by Pavel Machek

Subject: Re: kernel/stop_machine.c: whose code is it?

Hi!

> > > Would kernel/stop_machine.c author please step up?
> >
> > IMHO it's Rusty Russell (added to CC).
>
> Yep. Not sure the obsession with copyright on every trivial piece of
> code is healthy, but if it keeps you happy (I had to look back: this
> code was extracted from the module.c code in 2005).

I'd say it is definitely unhealthy, but knowing whose area of
expertise particular file is is sometimes helpful.

Thanks!
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

--
VGER BF report: U 0.500026