2006-09-04 09:24:40

by Martin Schwidefsky

[permalink] [raw]
Subject: [S390] Missing initialization in common i/o layer.

From: Heiko Carstens <[email protected]>

[S390] Missing initialization in common i/o layer.

Previous patch that was intended to reduce stack usage within common
i/o layer didn't consider implicit memset(..., 0, ...) used with the
initializations used before.
Add these missing memsets wherever it's not obvious that the
concerned memory region is zeroed. This should give the same semantics
as before.

Signed-off-by: Heiko Carstens <[email protected]>
Signed-off-by: Martin Schwidefsky <[email protected]>
---

drivers/s390/cio/device_fsm.c | 1 +
1 files changed, 1 insertion(+)

diff -urpN linux-2.6/drivers/s390/cio/device_fsm.c linux-2.6-patched/drivers/s390/cio/device_fsm.c
--- linux-2.6/drivers/s390/cio/device_fsm.c 2006-09-04 11:08:22.000000000 +0200
+++ linux-2.6-patched/drivers/s390/cio/device_fsm.c 2006-09-04 11:08:59.000000000 +0200
@@ -267,6 +267,7 @@ ccw_device_recog_done(struct ccw_device
notify = 1;
}
/* fill out sense information */
+ memset(&cdev->id, 0, sizeof(cdev->id));
cdev->id.cu_type = cdev->private->senseid.cu_type;
cdev->id.cu_model = cdev->private->senseid.cu_model;
cdev->id.dev_type = cdev->private->senseid.dev_type;

--
VGER BF report: U 0.495386