LinuxLists.cc - 2.6.18-rc6-mm1 2.6.18-rc5-mm1 Kernel Panic on X60s

[permalink] [raw]

Subject: Re: 2.6.18-rc6-mm1 2.6.18-rc5-mm1 Kernel Panic on X60s

On Fri, 8 Sep 2006 12:44:37 -0500
Brandon Philips <[email protected]> wrote:

> Under both 2.6.18-rc6-mm1 and 2.6.18-rc5-mm1 my Thinkpad X60s[1] crashes
> almost immediatly on boot with the following stack trace (typed by
> hand):
>
> Code: Bad EIP value.
> EIP: [<00000000>] run_init_process+0x3feffc9c/0x19 SS:ESP 0068:c0345f74
> <0>Kernel panic - not syncing: Fatal exception in interrupt
> BUG: warning at arch/i386/kernel.smp.c:547/smp_call_function()
> [<c01107e8>] smp_call_function+0x50/0x101
> [<c01172c2>] bug_spinlocks+0x3d/0x46
> [<c01108a9>] smp_send_stop+0x10/0x1b
> [<c0110a20>] stop_this_cpu+0x0/0x2e
> [<c011eefe>] panic+0x4d/0xe7
> [<c0104072>] die+0x26e/0x2a3
> [<c011772f>] do_page_fault+0x43d/0x50a
> [<c01172f2>] do_page_fault+0x0/0x50a
> [<c02a7a8f>] error_code+0x3f/0x44
> [<c01100d8>] acpi_copy_wakeup_routine+0x78/0x9a
> [<c01051ae>] do_IRQ+0x53/0x65
> [<c01036bf>] common_interrupt+0x23/0x28
> [<f883e714>] acpi_processor_idle+0x1f4/0x3b0 [processor]
> [<c0101c0e>] cpu_idle+0x9e/0xb7
> [<c034a711>] start_kernel+0x367/0x36d

Looks like we have an IRQ handler which is screwed up.

> 2.6.18-rc4-mm3 boots ok.
>
> I will try and bisect the problem later tonight-
>

Thanks. First, try disabling CONFIG_PCI_MSI.

2006-09-08 19:42:54

[permalink] [raw]

Subject: Re: 2.6.18-rc6-mm1 2.6.18-rc5-mm1 Kernel Panic on X60s

On 12:13 Fri 08 Sep 2006, Andrew Morton wrote:
> On Fri, 8 Sep 2006 12:44:37 -0500
> Brandon Philips <[email protected]> wrote:
> > 2.6.18-rc4-mm3 boots ok.
> >
> > I will try and bisect the problem later tonight-
>
> Thanks. First, try disabling CONFIG_PCI_MSI.

With CONFIG_PCI_MSI disabled the system boots.

However, udev seems to very upset about network device names:

[udevd:3951]: Changing netdevice name from [eth1_temp] to [eth0]

That showed up a few hundred times. I am running version 093 so I will
try updating that later.

Thanks!

Brandon

2006-09-08 19:54:21

[permalink] [raw]

Subject: Re: 2.6.18-rc6-mm1 2.6.18-rc5-mm1 Kernel Panic on X60s

On Fri, 8 Sep 2006 14:43:00 -0500
Brandon Philips <[email protected]> wrote:

> On 12:13 Fri 08 Sep 2006, Andrew Morton wrote:
> > On Fri, 8 Sep 2006 12:44:37 -0500
> > Brandon Philips <[email protected]> wrote:
> > > 2.6.18-rc4-mm3 boots ok.
> > >
> > > I will try and bisect the problem later tonight-
> >
> > Thanks. First, try disabling CONFIG_PCI_MSI.
>
> With CONFIG_PCI_MSI disabled the system boots.

OK, thanks.

So likely candidates are:

- Brice's MSI changes

- The conversion of i386 to use the genirq code

- Eric's MSI/genirq changes

or a combination of the above. Or something else.

<adds ccs, steps back expectantly>

> However, udev seems to very upset about network device names:
>
> [udevd:3951]: Changing netdevice name from [eth1_temp] to [eth0]
>
> That showed up a few hundred times. I am running version 093 so I will
> try updating that later.

That's OK - it's a debug patch which was added to help us work out why one
or two people's net device names are getting trashed. In fact we tracked
it down to some silliness in NetworkMonitor, regarding which certain parties
have yet to respond, iirc.

2006-09-09 02:22:10

by Benoit Boissinot

[permalink] [raw]

Subject: Re: 2.6.18-rc6-mm1 2.6.18-rc5-mm1 Kernel Panic on X60s

On 9/8/06, Andrew Morton <[email protected]> wrote:
> On Fri, 8 Sep 2006 14:43:00 -0500
> Brandon Philips <[email protected]> wrote:
>
> > However, udev seems to very upset about network device names:
> >
> > [udevd:3951]: Changing netdevice name from [eth1_temp] to [eth0]
> >
> > That showed up a few hundred times. I am running version 093 so I will
> > try updating that later.
>
> That's OK - it's a debug patch which was added to help us work out why one
> or two people's net device names are getting trashed. In fact we tracked
> it down to some silliness in NetworkMonitor, regarding which certain parties
> have yet to respond, iirc.
>
By the way, I don't use Network Manager, but wpa_supplicant (which is
used by networkmanager), and the device name corruption still happens
(but I think it is a userspace problem).

regards,

Benoit

2006-09-09 03:29:07

[permalink] [raw]

Subject: Re: 2.6.18-rc6-mm1 2.6.18-rc5-mm1 Kernel Panic on X60s

Andrew Morton <[email protected]> writes:

> On Fri, 8 Sep 2006 14:43:00 -0500
> Brandon Philips <[email protected]> wrote:
>
>> On 12:13 Fri 08 Sep 2006, Andrew Morton wrote:
>> > On Fri, 8 Sep 2006 12:44:37 -0500
>> > Brandon Philips <[email protected]> wrote:
>> > > 2.6.18-rc4-mm3 boots ok.
>> > >
>> > > I will try and bisect the problem later tonight-
>> >
>> > Thanks. First, try disabling CONFIG_PCI_MSI.
>>
>> With CONFIG_PCI_MSI disabled the system boots.
>
> OK, thanks.
>
> So likely candidates are:
>
> - Brice's MSI changes
>
> - The conversion of i386 to use the genirq code
>
> - Eric's MSI/genirq changes
>
> or a combination of the above. Or something else.
>
> <adds ccs, steps back expectantly>

Thanks for the heads up.

There was another panic reported last -mm tree I believe as well.

Eric

2006-09-09 05:25:12

[permalink] [raw]

Subject: Re: 2.6.18-rc6-mm1 2.6.18-rc5-mm1 Kernel Panic on X60s

On Fri, 08 Sep 2006 21:27:46 -0600
[email protected] (Eric W. Biederman) wrote:

> Andrew Morton <[email protected]> writes:
>
> > On Fri, 8 Sep 2006 14:43:00 -0500
> > Brandon Philips <[email protected]> wrote:
> >
> >> On 12:13 Fri 08 Sep 2006, Andrew Morton wrote:
> >> > On Fri, 8 Sep 2006 12:44:37 -0500
> >> > Brandon Philips <[email protected]> wrote:
> >> > > 2.6.18-rc4-mm3 boots ok.
> >> > >
> >> > > I will try and bisect the problem later tonight-
> >> >
> >> > Thanks. First, try disabling CONFIG_PCI_MSI.
> >>
> >> With CONFIG_PCI_MSI disabled the system boots.
> >
> > OK, thanks.
> >
> > So likely candidates are:
> >
> > - Brice's MSI changes
> >
> > - The conversion of i386 to use the genirq code
> >
> > - Eric's MSI/genirq changes
> >
> > or a combination of the above. Or something else.
> >
> > <adds ccs, steps back expectantly>
>
> Thanks for the heads up.
>
> There was another panic reported last -mm tree I believe as well.
>

Yes, there were a couple such reports. The MSI patches in Greg's tree were
blamed and rc6-mm1 has a revamped version. Whether they were sufficiently
revamped we do not know.

2006-09-09 05:48:24

by Brice Goglin

[permalink] [raw]

Subject: Re: 2.6.18-rc6-mm1 2.6.18-rc5-mm1 Kernel Panic on X60s

Andrew Morton wrote:
> On Fri, 08 Sep 2006 21:27:46 -0600
> [email protected] (Eric W. Biederman) wrote:
>
>> Andrew Morton <[email protected]> writes:
>>
>>> On Fri, 8 Sep 2006 14:43:00 -0500
>>> Brandon Philips <[email protected]> wrote:
>>>
>>>> With CONFIG_PCI_MSI disabled the system boots.
>>>>
>>> OK, thanks.
>>>
>>> So likely candidates are:
>>>
>>> - Brice's MSI changes
>>>
>>> - The conversion of i386 to use the genirq code
>>>
>>> - Eric's MSI/genirq changes
>>>
>>> or a combination of the above. Or something else.
>>>
>>> <adds ccs, steps back expectantly>
>>>
>> Thanks for the heads up.
>>
>> There was another panic reported last -mm tree I believe as well.
>>
>
> Yes, there were a couple such reports. The MSI patches in Greg's tree were
> blamed and rc6-mm1 has a revamped version. Whether they were sufficiently
> revamped we do not know.
>

The revamped version is much simpler than the previous ones. We are
basically back to the early ones we had in 2.6.17-mm5, with a tiny
modification to fix the oops that was reported there.

AFAIK, the possible problems that my patches might generate should only be:
* an obvious bug in the code leading to an oops during pci_enable_msi()
or pci_enable_msix() ;
* a wrong detection of whether MSI are supported or not, leading to MSI
being disabled while supported (should not be bad for most drivers), or
enabled while unsupported by the root chipset (would be bad).

Do we have Brandon lspci so that I can see if any of the MSI quirks is
involved?

Brice

2006-09-09 06:01:10

[permalink] [raw]

Subject: Re: 2.6.18-rc6-mm1 2.6.18-rc5-mm1 Kernel Panic on X60s

On 01:47 Sat 09 Sep 2006, Brice Goglin wrote:
> Andrew Morton wrote:
> > On Fri, 08 Sep 2006 21:27:46 -0600
> > [email protected] (Eric W. Biederman) wrote:
> >
> >> Andrew Morton <[email protected]> writes:
> >>
> >>> On Fri, 8 Sep 2006 14:43:00 -0500
> >>> Brandon Philips <[email protected]> wrote:
> >>>
> >>>> With CONFIG_PCI_MSI disabled the system boots.
> >>>>
> >>> OK, thanks.
> >>>
> >>> So likely candidates are:
> >>>
> >>> - Brice's MSI changes
> >>>
> >> Thanks for the heads up.
> >>
> >> There was another panic reported last -mm tree I believe as well.
> >>
> >
> > Yes, there were a couple such reports. The MSI patches in Greg's tree were
> > blamed and rc6-mm1 has a revamped version. Whether they were sufficiently
> > revamped we do not know.
> >
>
> Do we have Brandon lspci so that I can see if any of the MSI quirks is
> involved?

lspci -vv on my Thinkpad x60s

00:00.0 Host bridge: Intel Corporation Mobile 945GM/PM/GMS/940GML and 945GT Express Memory Controller Hub (rev 03)
Subsystem: Lenovo Thinkpad R60e model 0657
Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B-
Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort+ >SERR- <PERR-
Latency: 0
Capabilities: [e0] Vendor Specific Information

00:02.0 VGA compatible controller: Intel Corporation Mobile 945GM/GMS/940GML Express Integrated Graphics Controller (rev 03) (prog-if 00 [VGA])
Subsystem: Lenovo Thinkpad R60e model 0657
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 0
Interrupt: pin A routed to IRQ 20
Region 0: Memory at ee100000 (32-bit, non-prefetchable) [size=512K]
Region 1: I/O ports at 1800 [size=8]
Region 2: Memory at d0000000 (32-bit, prefetchable) [size=256M]
Region 3: Memory at ee200000 (32-bit, non-prefetchable) [size=256K]
Capabilities: [90] Message Signalled Interrupts: Mask- 64bit- Queue=0/0 Enable-
Address: 00000000 Data: 0000
Capabilities: [d0] Power Management version 2
Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-

00:02.1 Display controller: Intel Corporation Mobile 945GM/GMS/940GML Express Integrated Graphics Controller (rev 03)
Subsystem: Lenovo Thinkpad R60e model 0657
Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Region 0: Memory at ee180000 (32-bit, non-prefetchable) [size=512K]
Capabilities: [d0] Power Management version 2
Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-

00:1b.0 Audio device: Intel Corporation 82801G (ICH7 Family) High Definition Audio Controller (rev 02)
Subsystem: Lenovo Thinkpad R60e model 0657
Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 0, Cache Line Size: 64 bytes
Interrupt: pin B routed to IRQ 21
Region 0: Memory at ee240000 (64-bit, non-prefetchable) [size=16K]
Capabilities: [50] Power Management version 2
Flags: PMEClk- DSI- D1- D2- AuxCurrent=55mA PME(D0+,D1-,D2-,D3hot+,D3cold+)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
Capabilities: [60] Message Signalled Interrupts: Mask- 64bit+ Queue=0/0 Enable-
Address: 0000000000000000 Data: 0000
Capabilities: [70] Express Unknown type IRQ 0
Device: Supported: MaxPayload 128 bytes, PhantFunc 0, ExtTag-
Device: Latency L0s <64ns, L1 <1us
Device: Errors: Correctable- Non-Fatal- Fatal- Unsupported-
Device: RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop+
Device: MaxPayload 128 bytes, MaxReadReq 128 bytes
Link: Supported Speed unknown, Width x0, ASPM unknown, Port 0
Link: Latency L0s <64ns, L1 <1us
Link: ASPM Disabled CommClk- ExtSynch-
Link: Speed unknown, Width x0
Capabilities: [100] Virtual Channel
Capabilities: [130] Unknown (5)

00:1c.0 PCI bridge: Intel Corporation 82801G (ICH7 Family) PCI Express Port 1 (rev 02) (prog-if 00 [Normal decode])
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 0, Cache Line Size: 64 bytes
Bus: primary=00, secondary=02, subordinate=02, sec-latency=0
I/O behind bridge: 00002000-00002fff
Memory behind bridge: ee000000-ee0fffff
Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- <SERR- <PERR-
BridgeCtl: Parity- SERR- NoISA+ VGA- MAbort- >Reset- FastB2B-
Capabilities: [40] Express Root Port (Slot+) IRQ 0
Device: Supported: MaxPayload 128 bytes, PhantFunc 0, ExtTag-
Device: Latency L0s unlimited, L1 unlimited
Device: Errors: Correctable- Non-Fatal- Fatal- Unsupported-
Device: RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop-
Device: MaxPayload 128 bytes, MaxReadReq 128 bytes
Link: Supported Speed 2.5Gb/s, Width x1, ASPM L0s L1, Port 1
Link: Latency L0s <256ns, L1 <4us
Link: ASPM L1 Enabled RCB 64 bytes CommClk+ ExtSynch-
Link: Speed 2.5Gb/s, Width x1
Slot: AtnBtn- PwrCtrl- MRL- AtnInd- PwrInd- HotPlug+ Surpise+
Slot: Number 2, PowerLimit 6.500000
Slot: Enabled AtnBtn- PwrFlt- MRL- PresDet- CmdCplt- HPIrq-
Slot: AttnInd Unknown, PwrInd Unknown, Power-
Root: Correctable- Non-Fatal- Fatal- PME-
Capabilities: [80] Message Signalled Interrupts: Mask- 64bit- Queue=0/0 Enable-
Address: 00000000 Data: 0000
Capabilities: [90] Subsystem: Lenovo Unknown device 2011
Capabilities: [a0] Power Management version 2
Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0+,D1-,D2-,D3hot+,D3cold+)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
Capabilities: [100] Virtual Channel
Capabilities: [180] Unknown (5)

00:1c.1 PCI bridge: Intel Corporation 82801G (ICH7 Family) PCI Express Port 2 (rev 02) (prog-if 00 [Normal decode])
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 0, Cache Line Size: 64 bytes
Bus: primary=00, secondary=03, subordinate=03, sec-latency=0
I/O behind bridge: 00003000-00004fff
Memory behind bridge: ec000000-edffffff
Prefetchable memory behind bridge: 00000000e4000000-00000000e40fffff
Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- <SERR- <PERR-
BridgeCtl: Parity- SERR- NoISA+ VGA- MAbort- >Reset- FastB2B-
Capabilities: [40] Express Root Port (Slot+) IRQ 0
Device: Supported: MaxPayload 128 bytes, PhantFunc 0, ExtTag-
Device: Latency L0s unlimited, L1 unlimited
Device: Errors: Correctable- Non-Fatal- Fatal- Unsupported-
Device: RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop-
Device: MaxPayload 128 bytes, MaxReadReq 128 bytes
Link: Supported Speed 2.5Gb/s, Width x1, ASPM L0s L1, Port 2
Link: Latency L0s <256ns, L1 <4us
Link: ASPM L1 Enabled RCB 64 bytes CommClk+ ExtSynch-
Link: Speed 2.5Gb/s, Width x1
Slot: AtnBtn- PwrCtrl- MRL- AtnInd- PwrInd- HotPlug+ Surpise+
Slot: Number 3, PowerLimit 6.500000
Slot: Enabled AtnBtn- PwrFlt- MRL- PresDet- CmdCplt- HPIrq-
Slot: AttnInd Unknown, PwrInd Unknown, Power-
Root: Correctable- Non-Fatal- Fatal- PME-
Capabilities: [80] Message Signalled Interrupts: Mask- 64bit- Queue=0/0 Enable-
Address: 00000000 Data: 0000
Capabilities: [90] Subsystem: Lenovo Unknown device 2011
Capabilities: [a0] Power Management version 2
Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0+,D1-,D2-,D3hot+,D3cold+)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
Capabilities: [100] Virtual Channel
Capabilities: [180] Unknown (5)

00:1c.2 PCI bridge: Intel Corporation 82801G (ICH7 Family) PCI Express Port 3 (rev 02) (prog-if 00 [Normal decode])
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 0, Cache Line Size: 64 bytes
Bus: primary=00, secondary=04, subordinate=0b, sec-latency=0
I/O behind bridge: 00005000-00006fff
Memory behind bridge: e8000000-e9ffffff
Prefetchable memory behind bridge: 00000000e4100000-00000000e41fffff
Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort+ <SERR- <PERR-
BridgeCtl: Parity- SERR- NoISA+ VGA- MAbort- >Reset- FastB2B-
Capabilities: [40] Express Root Port (Slot+) IRQ 0
Device: Supported: MaxPayload 128 bytes, PhantFunc 0, ExtTag-
Device: Latency L0s unlimited, L1 unlimited
Device: Errors: Correctable- Non-Fatal- Fatal- Unsupported-
Device: RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop-
Device: MaxPayload 128 bytes, MaxReadReq 128 bytes
Link: Supported Speed 2.5Gb/s, Width x1, ASPM L0s L1, Port 3
Link: Latency L0s <1us, L1 <4us
Link: ASPM Disabled RCB 64 bytes CommClk- ExtSynch-
Link: Speed 2.5Gb/s, Width x0
Slot: AtnBtn- PwrCtrl- MRL- AtnInd- PwrInd- HotPlug+ Surpise+
Slot: Number 4, PowerLimit 6.500000
Slot: Enabled AtnBtn- PwrFlt- MRL- PresDet+ CmdCplt- HPIrq+
Slot: AttnInd Unknown, PwrInd Unknown, Power-
Root: Correctable- Non-Fatal- Fatal- PME-
Capabilities: [80] Message Signalled Interrupts: Mask- 64bit- Queue=0/0 Enable-
Address: 00000000 Data: 0000
Capabilities: [90] Subsystem: Lenovo Unknown device 2011
Capabilities: [a0] Power Management version 2
Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0+,D1-,D2-,D3hot+,D3cold+)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
Capabilities: [100] Virtual Channel
Capabilities: [180] Unknown (5)

00:1c.3 PCI bridge: Intel Corporation 82801G (ICH7 Family) PCI Express Port 4 (rev 02) (prog-if 00 [Normal decode])
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 0, Cache Line Size: 64 bytes
Bus: primary=00, secondary=0c, subordinate=13, sec-latency=0
I/O behind bridge: 00007000-00008fff
Memory behind bridge: ea000000-ebffffff
Prefetchable memory behind bridge: 00000000e4200000-00000000e42fffff
Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort+ <SERR- <PERR-
BridgeCtl: Parity- SERR- NoISA+ VGA- MAbort- >Reset- FastB2B-
Capabilities: [40] Express Root Port (Slot+) IRQ 0
Device: Supported: MaxPayload 128 bytes, PhantFunc 0, ExtTag-
Device: Latency L0s unlimited, L1 unlimited
Device: Errors: Correctable- Non-Fatal- Fatal- Unsupported-
Device: RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop-
Device: MaxPayload 128 bytes, MaxReadReq 128 bytes
Link: Supported Speed 2.5Gb/s, Width x1, ASPM L0s L1, Port 4
Link: Latency L0s <1us, L1 <4us
Link: ASPM Disabled RCB 64 bytes CommClk- ExtSynch-
Link: Speed 2.5Gb/s, Width x0
Slot: AtnBtn- PwrCtrl- MRL- AtnInd- PwrInd- HotPlug+ Surpise+
Slot: Number 5, PowerLimit 6.500000
Slot: Enabled AtnBtn- PwrFlt- MRL- PresDet- CmdCplt- HPIrq-
Slot: AttnInd Unknown, PwrInd Unknown, Power-
Root: Correctable- Non-Fatal- Fatal- PME-
Capabilities: [80] Message Signalled Interrupts: Mask- 64bit- Queue=0/0 Enable-
Address: 00000000 Data: 0000
Capabilities: [90] Subsystem: Lenovo Unknown device 2011
Capabilities: [a0] Power Management version 2
Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0+,D1-,D2-,D3hot+,D3cold+)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
Capabilities: [100] Virtual Channel
Capabilities: [180] Unknown (5)

00:1d.0 USB Controller: Intel Corporation 82801G (ICH7 Family) USB UHCI #1 (rev 02) (prog-if 00 [UHCI])
Subsystem: Lenovo Thinkpad R60e model 0657
Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 0
Interrupt: pin A routed to IRQ 20
Region 4: I/O ports at 1820 [size=32]

00:1d.1 USB Controller: Intel Corporation 82801G (ICH7 Family) USB UHCI #2 (rev 02) (prog-if 00 [UHCI])
Subsystem: Lenovo Thinkpad R60e model 0657
Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 0
Interrupt: pin B routed to IRQ 21
Region 4: I/O ports at 1840 [size=32]

00:1d.2 USB Controller: Intel Corporation 82801G (ICH7 Family) USB UHCI #3 (rev 02) (prog-if 00 [UHCI])
Subsystem: Lenovo Thinkpad R60e model 0657
Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 0
Interrupt: pin C routed to IRQ 22
Region 4: I/O ports at 1860 [size=32]

00:1d.3 USB Controller: Intel Corporation 82801G (ICH7 Family) USB UHCI #4 (rev 02) (prog-if 00 [UHCI])
Subsystem: Lenovo Thinkpad R60e model 0657
Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 0
Interrupt: pin D routed to IRQ 23
Region 4: I/O ports at 1880 [size=32]

00:1d.7 USB Controller: Intel Corporation 82801G (ICH7 Family) USB2 EHCI Controller (rev 02) (prog-if 20 [EHCI])
Subsystem: Lenovo Thinkpad R60e model 0657
Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B-
Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 0
Interrupt: pin D routed to IRQ 23
Region 0: Memory at ee444000 (32-bit, non-prefetchable) [size=1K]
Capabilities: [50] Power Management version 2
Flags: PMEClk- DSI- D1- D2- AuxCurrent=375mA PME(D0+,D1-,D2-,D3hot+,D3cold+)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
Capabilities: [58] Debug port

00:1e.0 PCI bridge: Intel Corporation 82801 Mobile PCI Bridge (rev e2) (prog-if 01 [Subtractive decode])
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 0
Bus: primary=00, secondary=15, subordinate=18, sec-latency=32
I/O behind bridge: 00009000-0000cfff
Memory behind bridge: e4300000-e7ffffff
Prefetchable memory behind bridge: 00000000e0000000-00000000e3ffffff
Secondary status: 66MHz- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort+ <SERR- <PERR-
BridgeCtl: Parity- SERR- NoISA- VGA- MAbort- >Reset- FastB2B-
Capabilities: [50] Subsystem: Lenovo Unknown device 2013

00:1f.0 ISA bridge: Intel Corporation 82801GBM (ICH7-M) LPC Interface Bridge (rev 02)
Subsystem: Lenovo Thinkpad R60e model 0657
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 0
Capabilities: [e0] Vendor Specific Information

00:1f.1 IDE interface: Intel Corporation 82801G (ICH7 Family) IDE Controller (rev 02) (prog-if 8a [Master SecP PriP])
Subsystem: Lenovo Thinkpad R60e model 0657
Control: I/O+ Mem- BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 0
Interrupt: pin C routed to IRQ 20
Region 0: I/O ports at <unassigned>
Region 1: I/O ports at <unassigned>
Region 2: I/O ports at <unassigned>
Region 3: I/O ports at <unassigned>
Region 4: I/O ports at 1810 [size=16]

00:1f.2 SATA controller: Intel Corporation 82801GBM/GHM (ICH7 Family) Serial ATA Storage Controller AHCI (rev 02) (prog-if 01 [AHCI 1.0])
Subsystem: Lenovo Thinkpad R60e model 0657
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 0
Interrupt: pin B routed to IRQ 20
Region 0: I/O ports at 18d0 [size=8]
Region 1: I/O ports at 18c4 [size=4]
Region 2: I/O ports at 18c8 [size=8]
Region 3: I/O ports at 18c0 [size=4]
Region 4: I/O ports at 18b0 [size=16]
Region 5: Memory at ee444400 (32-bit, non-prefetchable) [size=1K]
Capabilities: [80] Message Signalled Interrupts: Mask- 64bit- Queue=0/0 Enable-
Address: 00000000 Data: 0000
Capabilities: [70] Power Management version 2
Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot+,D3cold-)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-

00:1f.3 SMBus: Intel Corporation 82801G (ICH7 Family) SMBus Controller (rev 02)
Subsystem: Lenovo Thinkpad R60e model 0657
Control: I/O+ Mem- BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B-
Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Interrupt: pin A routed to IRQ 19
Region 4: I/O ports at 18e0 [size=32]

02:00.0 Ethernet controller: Intel Corporation 82573L Gigabit Ethernet Controller
Subsystem: Lenovo Thinkpad X60s
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 0, Cache Line Size: 64 bytes
Interrupt: pin A routed to IRQ 20
Region 0: Memory at ee000000 (32-bit, non-prefetchable) [size=128K]
Region 2: I/O ports at 2000 [size=32]
Capabilities: [c8] Power Management version 2
Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA PME(D0+,D1-,D2-,D3hot+,D3cold+)
Status: D0 PME-Enable- DSel=0 DScale=1 PME-
Capabilities: [d0] Message Signalled Interrupts: Mask- 64bit+ Queue=0/0 Enable-
Address: 0000000000000000 Data: 0000
Capabilities: [e0] Express Endpoint IRQ 0
Device: Supported: MaxPayload 256 bytes, PhantFunc 0, ExtTag-
Device: Latency L0s <512ns, L1 <64us
Device: AtnBtn- AtnInd- PwrInd-
Device: Errors: Correctable- Non-Fatal- Fatal- Unsupported-
Device: RlxdOrd+ ExtTag- PhantFunc- AuxPwr- NoSnoop+
Device: MaxPayload 128 bytes, MaxReadReq 512 bytes
Link: Supported Speed 2.5Gb/s, Width x1, ASPM L0s L1, Port 0
Link: Latency L0s <128ns, L1 <64us
Link: ASPM L1 Enabled RCB 64 bytes CommClk+ ExtSynch-
Link: Speed 2.5Gb/s, Width x1
Capabilities: [100] Advanced Error Reporting
Capabilities: [140] Device Serial Number xx-xx-xx-xx-xx-xx-xx-xx

03:00.0 Network controller: Intel Corporation PRO/Wireless 3945ABG Network Connection (rev 02)
Subsystem: Intel Corporation Unknown device 1010
Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR+ FastB2B-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 0, Cache Line Size: 64 bytes
Interrupt: pin A routed to IRQ 21
Region 0: Memory at edf00000 (32-bit, non-prefetchable) [size=4K]
Capabilities: [c8] Power Management version 2
Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA PME(D0+,D1-,D2-,D3hot+,D3cold+)
Status: D0 PME-Enable- DSel=0 DScale=0 PME-
Capabilities: [d0] Message Signalled Interrupts: Mask- 64bit+ Queue=0/0 Enable-
Address: 0000000000000000 Data: 0000
Capabilities: [e0] Express Legacy Endpoint IRQ 0
Device: Supported: MaxPayload 128 bytes, PhantFunc 0, ExtTag-
Device: Latency L0s <512ns, L1 unlimited
Device: AtnBtn- AtnInd- PwrInd-
Device: Errors: Correctable- Non-Fatal- Fatal- Unsupported-
Device: RlxdOrd+ ExtTag- PhantFunc- AuxPwr- NoSnoop+
Device: MaxPayload 128 bytes, MaxReadReq 128 bytes
Link: Supported Speed 2.5Gb/s, Width x1, ASPM L0s L1, Port 0
Link: Latency L0s <128ns, L1 <64us
Link: ASPM L1 Enabled RCB 64 bytes CommClk+ ExtSynch-
Link: Speed 2.5Gb/s, Width x1
Capabilities: [100] Advanced Error Reporting
Capabilities: [140] Device Serial Number xx-xx-xx-xx-xx-xx-xx-xx

15:00.0 CardBus bridge: Ricoh Co Ltd RL5c476 II (rev b4)
Subsystem: Lenovo Thinkpad X60s
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 168
Interrupt: pin A routed to IRQ 20
Region 0: Memory at e4300000 (32-bit, non-prefetchable) [size=4K]
Bus: primary=15, secondary=16, subordinate=17, sec-latency=176
Memory window 0: e0000000-e1fff000 (prefetchable)
Memory window 1: e6000000-e7fff000
I/O window 0: 00009000-000090ff
I/O window 1: 00009400-000094ff
BridgeCtl: Parity- SERR- ISA- VGA- MAbort- >Reset- 16bInt+ PostWrite+
16-bit legacy interface ports at 0001

15:00.1 FireWire (IEEE 1394): Ricoh Co Ltd R5C552 IEEE 1394 Controller (rev 09) (prog-if 10 [OHCI])
Subsystem: Lenovo Thinkpad X60s
Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 64 (500ns min, 1000ns max)
Interrupt: pin B routed to IRQ 21
Region 0: Memory at e4301000 (32-bit, non-prefetchable) [size=2K]
Capabilities: [dc] Power Management version 2
Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0+,D1-,D2-,D3hot+,D3cold+)
Status: D0 PME-Enable- DSel=0 DScale=2 PME+

15:00.2 Generic system peripheral [0805]: Ricoh Co Ltd R5C822 SD/SDIO/MMC/MS/MSPro Host Adapter (rev 18)
Subsystem: Lenovo Thinkpad X60s
Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B-
Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- <TAbort- <MAbort- >SERR- <PERR-
Latency: 0
Interrupt: pin C routed to IRQ 11
Region 0: Memory at e4301800 (32-bit, non-prefetchable) [size=256]
Capabilities: [80] Power Management version 2
Flags: PMEClk- DSI- D1+ D2+ AuxCurrent=0mA PME(D0+,D1+,D2+,D3hot+,D3cold+)
Status: D0 PME-Enable- DSel=0 DScale=2 PME-

2006-09-09 06:15:28

by Brice Goglin

[permalink] [raw]

Subject: Re: 2.6.18-rc6-mm1 2.6.18-rc5-mm1 Kernel Panic on X60s

Brandon Philips wrote:
> On 01:47 Sat 09 Sep 2006, Brice Goglin wrote:
>> Do we have Brandon lspci so that I can see if any of the MSI quirks is
>> involved?
>
> 00:00.0 Host bridge: Intel Corporation Mobile 945GM/PM/GMS/940GML and 945GT Express Memory Controller Hub (rev 03)
> 00:1c.0 PCI bridge: Intel Corporation 82801G (ICH7 Family) PCI Express Port 1 (rev 02) (prog-if 00 [Normal decode])
> 00:1c.1 PCI bridge: Intel Corporation 82801G (ICH7 Family) PCI Express Port 2 (rev 02) (prog-if 00 [Normal decode])
> 00:1c.2 PCI bridge: Intel Corporation 82801G (ICH7 Family) PCI Express Port 3 (rev 02) (prog-if 00 [Normal decode])
> 00:1c.3 PCI bridge: Intel Corporation 82801G (ICH7 Family) PCI Express Port 4 (rev 02) (prog-if 00 [Normal decode])
> 00:1e.0 PCI bridge: Intel Corporation 82801 Mobile PCI Bridge (rev e2) (prog-if 01 [Subtractive decode])
>

There is no MSI quirk for these chipsets, MSI work fine on Intel.

Let me know if your dichotomy leads to one of the following patches:

1) gregkh-pci-msi-cleanup-existing-msi-quirks.patch
2) gregkh-pci-msi-factorize-common-code-in-pci_msi_supported.patch
3) gregkh-pci-msi-export-the-pci_bus_flags_no_msi-flag-in-sysfs.patch
4)
gregkh-pci-msi-blacklist-pci-e-chipsets-depending-on-hypertransport-msi-capability.patch
5)
fix-gregkh-pci-msi-blacklist-pci-e-chipsets-depending-on-hypertransport-msi-capability.patch

(only (1) and (2) should be relevant here)

thanks,
Brice

2006-09-11 02:13:50

[permalink] [raw]

Subject: Re: 2.6.18-rc6-mm1 2.6.18-rc5-mm1 Kernel Panic on X60s

On 12:50 Fri 08 Sep 2006, Andrew Morton wrote:
> On Fri, 8 Sep 2006 14:43:00 -0500
> Brandon Philips <[email protected]> wrote:
> > On 12:13 Fri 08 Sep 2006, Andrew Morton wrote:
> > > On Fri, 8 Sep 2006 12:44:37 -0500
> > > Brandon Philips <[email protected]> wrote:
> > > > 2.6.18-rc4-mm3 boots ok.
> > > >
> > > > I will try and bisect the problem later tonight-
> > >
> > > Thanks. First, try disabling CONFIG_PCI_MSI.
> >
> > With CONFIG_PCI_MSI disabled the system boots.
>
> OK, thanks.
>
> So likely candidates are:
>
> - The conversion of i386 to use the genirq code

genirq-convert-the-i386-architecture-to-irq-chips.patch is causing the
Kernel panic.

Thanks,

Brandon

2006-09-11 16:56:26

[permalink] [raw]

Subject: Re: 2.6.18-rc6-mm1 2.6.18-rc5-mm1 Kernel Panic on X60s

On Sun, 10 Sep 2006 21:14:00 -0500
Brandon Philips <[email protected]> wrote:

> On 12:50 Fri 08 Sep 2006, Andrew Morton wrote:
> > On Fri, 8 Sep 2006 14:43:00 -0500
> > Brandon Philips <[email protected]> wrote:
> > > On 12:13 Fri 08 Sep 2006, Andrew Morton wrote:
> > > > On Fri, 8 Sep 2006 12:44:37 -0500
> > > > Brandon Philips <[email protected]> wrote:
> > > > > 2.6.18-rc4-mm3 boots ok.
> > > > >
> > > > > I will try and bisect the problem later tonight-
> > > >
> > > > Thanks. First, try disabling CONFIG_PCI_MSI.
> > >
> > > With CONFIG_PCI_MSI disabled the system boots.
> >
> > OK, thanks.
> >
> > So likely candidates are:
> >
> > - The conversion of i386 to use the genirq code
>
> genirq-convert-the-i386-architecture-to-irq-chips.patch is causing the
> Kernel panic.
>

OK, thanks.

I don't think this necessarily tells us where the bug lies. It could be
some pre-existing thing in MSI, or it could be added by Bryce's changes.
Or by Eric's. Or, of course, by
genirq-convert-the-i386-architecture-to-irq-chips.patch.

There doesn't seem to be a lot of movement on this and we want to get the
x86 genirq conversion into 2.6.19. Could be that we end up having to merge
known-buggy stuff into mainline and crash enough computers to irritate
someone into fixing it. Rather sad.

2006-09-11 17:56:59

[permalink] [raw]

Subject: Re: 2.6.18-rc6-mm1 2.6.18-rc5-mm1 Kernel Panic on X60s

Andrew Morton <[email protected]> writes:

> OK, thanks.
>
> I don't think this necessarily tells us where the bug lies. It could be
> some pre-existing thing in MSI, or it could be added by Bryce's changes.
> Or by Eric's. Or, of course, by
> genirq-convert-the-i386-architecture-to-irq-chips.patch.
>
> There doesn't seem to be a lot of movement on this and we want to get the
> x86 genirq conversion into 2.6.19. Could be that we end up having to merge
> known-buggy stuff into mainline and crash enough computers to irritate
> someone into fixing it. Rather sad.

My planning to take a good hard look at it, in a bit.
Since it was failing in do_IRQ with a page fault something is obviously being
left as NULL, so this should be quite easy to track down once we look
closely.

I'm very suspicious that this failure started happening in just
the last two -mm releases. That seems to implicate Bryce's work,
but if it is just about enabling MSI he should not have touched
the code path where the failure happened.

Also I noticed a little while ago that I didn't quite take the
msi code far enough. In particular the generic code still does some
apic accesses which doesn't make any sense at all for architectures
like ppc.

I'm currently sitting on a queue of 30 about 99% complete struct pid
conversions, that I just need to review one last time and then send
out to get merged, hopefully I can get the rest of these patches sent
out in the next day or two, so I can focus on irq issues for a bit.

Eric

2006-09-12 06:21:59

[permalink] [raw]

Subject: Re: 2.6.18-rc6-mm1 2.6.18-rc5-mm1 Kernel Panic on X60s

Andrew Morton <[email protected]> writes:

> OK, thanks.
>
> I don't think this necessarily tells us where the bug lies. It could be
> some pre-existing thing in MSI, or it could be added by Bryce's changes.
> Or by Eric's. Or, of course, by
> genirq-convert-the-i386-architecture-to-irq-chips.patch.
>
> There doesn't seem to be a lot of movement on this and we want to get the
> x86 genirq conversion into 2.6.19. Could be that we end up having to merge
> known-buggy stuff into mainline and crash enough computers to irritate
> someone into fixing it. Rather sad.

Ok. Looking at it I almost certain the problem is that
we lost the hunk of code removed in: 266f0566761cf88906d634727b3d9fc2556f5cbd
i386: Fix stack switching in do_IRQ

- if (!irq_desc[irq].handle_irq) {
- __do_IRQ(irq, regs);
- goto out_exit;
- }

The msi code does not yet set desc->handle_irq. So when we attempt
to call it we get a NULL pointer dereference.

Except for adding that hunk back in and breaking 4K stacks I don't
have an immediate fix.

I do have a pending cleanup that should result in us setting handle_irq
in all cases. I will see if I can advance that shortly.

Eric

2006-09-12 07:59:15

by Ingo Molnar

[permalink] [raw]

Subject: [patch] genirq/MSI: restore __do_IRQ() compat logic temporarily

* Eric W. Biederman <[email protected]> wrote:

> Ok. Looking at it I almost certain the problem is that
> we lost the hunk of code removed in: 266f0566761cf88906d634727b3d9fc2556f5cbd
> i386: Fix stack switching in do_IRQ
>
> - if (!irq_desc[irq].handle_irq) {
> - __do_IRQ(irq, regs);
> - goto out_exit;
> - }
>
> The msi code does not yet set desc->handle_irq. So when we attempt to
> call it we get a NULL pointer dereference.

indeed ... We thought the MSI cleanup went all the way with the irqchips
conversion, that's we suggested to Andrew to drop this chunk in -mm too.

> Except for adding that hunk back in and breaking 4K stacks I don't
> have an immediate fix.

i've attached a bandaid patch for -mm below. Brandon, does this solve
the crash you are seeing?

> I do have a pending cleanup that should result in us setting
> handle_irq in all cases. I will see if I can advance that shortly.

yeah, that's the right solution.

Ingo

------------------>
Subject: [patch] genirq/MSI: restore __do_IRQ() compat logic temporarily
From: Ingo Molnar <[email protected]>

restore the __do_IRQ() compat logic temporarily, until the MSI
genirq conversion has been completed.

disable 4KSTACKS temporarily too.

Signed-off-by: Ingo Molnar <[email protected]>

---
arch/i386/Kconfig.debug | 4 ++++
arch/i386/kernel/irq.c | 5 +++++
2 files changed, 9 insertions(+)

Index: linux-2.6.18-rc6-mm1/arch/i386/Kconfig.debug
===================================================================
--- linux-2.6.18-rc6-mm1.orig/arch/i386/Kconfig.debug
+++ linux-2.6.18-rc6-mm1/arch/i386/Kconfig.debug
@@ -56,8 +56,12 @@ config DEBUG_RODATA
portion of the kernel code won't be covered by a 2MB TLB anymore.
If in doubt, say "N".

+#
+# FIXME: Disabled temporarily until the MSI genirq conversion is done!
+#
config 4KSTACKS
bool "Use 4Kb + 4Kb for kernel stacks instead of 8Kb" if DEBUG_KERNEL
+ depends on n
default y
help
If you say Y here the kernel will use a 4Kb stacksize for the
Index: linux-2.6.18-rc6-mm1/arch/i386/kernel/irq.c
===================================================================
--- linux-2.6.18-rc6-mm1.orig/arch/i386/kernel/irq.c
+++ linux-2.6.18-rc6-mm1/arch/i386/kernel/irq.c
@@ -83,6 +83,10 @@ fastcall unsigned int do_IRQ(struct pt_r
}
#endif

+ if (!irq_desc[irq].handle_irq) {
+ __do_IRQ(irq, regs);
+ goto out_exit;
+ }
#ifdef CONFIG_4KSTACKS

curctx = (union irq_ctx *) current_thread_info();
@@ -123,6 +127,7 @@ fastcall unsigned int do_IRQ(struct pt_r
#endif
desc->handle_irq(irq, desc, regs);

+out_exit:
irq_exit();

return 1;

2006-09-12 12:44:46

[permalink] [raw]

Subject: Re: [patch] genirq/MSI: restore __do_IRQ() compat logic temporarily

On 09:50 Tue 12 Sep 2006, Ingo Molnar wrote:
> * Eric W. Biederman <[email protected]> wrote:
> > Ok. Looking at it I almost certain the problem is that
> > we lost the hunk of code removed in: 266f0566761cf88906d634727b3d9fc2556f5cbd
> > i386: Fix stack switching in do_IRQ
> >
> > - if (!irq_desc[irq].handle_irq) {
> > - __do_IRQ(irq, regs);
> > - goto out_exit;
> > - }
> >
> > The msi code does not yet set desc->handle_irq. So when we attempt to
> > call it we get a NULL pointer dereference.
>
> indeed ... We thought the MSI cleanup went all the way with the irqchips
> conversion, that's we suggested to Andrew to drop this chunk in -mm too.
>
> > Except for adding that hunk back in and breaking 4K stacks I don't
> > have an immediate fix.
>
> i've attached a bandaid patch for -mm below. Brandon, does this solve
> the crash you are seeing?

Indeed- this patch makes the system bootable.

I will keep up on the -mm tree as this conversion continues and let all
of you know if things break again :-)

Thanks,

Brandon

> ------------------>
> Subject: [patch] genirq/MSI: restore __do_IRQ() compat logic temporarily
> From: Ingo Molnar <[email protected]>
>
> restore the __do_IRQ() compat logic temporarily, until the MSI
> genirq conversion has been completed.
>
> disable 4KSTACKS temporarily too.
>
> Signed-off-by: Ingo Molnar <[email protected]>
>
> ---
> arch/i386/Kconfig.debug | 4 ++++
> arch/i386/kernel/irq.c | 5 +++++
> 2 files changed, 9 insertions(+)
>
> Index: linux-2.6.18-rc6-mm1/arch/i386/Kconfig.debug
> ===================================================================
> --- linux-2.6.18-rc6-mm1.orig/arch/i386/Kconfig.debug
> +++ linux-2.6.18-rc6-mm1/arch/i386/Kconfig.debug
> @@ -56,8 +56,12 @@ config DEBUG_RODATA
> portion of the kernel code won't be covered by a 2MB TLB anymore.
> If in doubt, say "N".
>
> +#
> +# FIXME: Disabled temporarily until the MSI genirq conversion is done!
> +#
> config 4KSTACKS
> bool "Use 4Kb + 4Kb for kernel stacks instead of 8Kb" if DEBUG_KERNEL
> + depends on n
> default y
> help
> If you say Y here the kernel will use a 4Kb stacksize for the
> Index: linux-2.6.18-rc6-mm1/arch/i386/kernel/irq.c
> ===================================================================
> --- linux-2.6.18-rc6-mm1.orig/arch/i386/kernel/irq.c
> +++ linux-2.6.18-rc6-mm1/arch/i386/kernel/irq.c
> @@ -83,6 +83,10 @@ fastcall unsigned int do_IRQ(struct pt_r
> }
> #endif
>
> + if (!irq_desc[irq].handle_irq) {
> + __do_IRQ(irq, regs);
> + goto out_exit;
> + }
> #ifdef CONFIG_4KSTACKS
>
> curctx = (union irq_ctx *) current_thread_info();
> @@ -123,6 +127,7 @@ fastcall unsigned int do_IRQ(struct pt_r
> #endif
> desc->handle_irq(irq, desc, regs);
>
> +out_exit:
> irq_exit();
>
> return 1;

2006-09-12 14:43:10