2006-09-13 18:48:25

by Corey Minyard

Subject: [PATCH] IPMI: fix handling of OEM flags

If one of the OEM flags becomes set in the flags from the
hardware, the driver could hang if no OEM handler was set.
Fix the code to handle this. This was tested by setting
the flags by hand after they were fetched.

Signed-off-by: Corey Minyard <[email protected]>
Cc: Matt Domsch <[email protected]>

Index: linux-2.6.17/drivers/char/ipmi/ipmi_si_intf.c
===================================================================
--- linux-2.6.17.orig/drivers/char/ipmi/ipmi_si_intf.c
+++ linux-2.6.17/drivers/char/ipmi/ipmi_si_intf.c
@@ -403,10 +403,10 @@ static void handle_flags(struct smi_info
smi_info->curr_msg->data,
smi_info->curr_msg->data_size);
smi_info->si_state = SI_GETTING_EVENTS;
- } else if (smi_info->msg_flags & OEM_DATA_AVAIL) {
- if (smi_info->oem_data_avail_handler)
- if (smi_info->oem_data_avail_handler(smi_info))
- goto retry;
+ } else if (smi_info->msg_flags & OEM_DATA_AVAIL &&
+ smi_info->oem_data_avail_handler) {
+ if (smi_info->oem_data_avail_handler(smi_info))
+ goto retry;
} else {
smi_info->si_state = SI_NORMAL;
}

2006-09-13 19:09:46

by Matt Domsch

Subject: Re: [PATCH] IPMI: fix handling of OEM flags

On Wed, Sep 13, 2006 at 01:50:12PM -0500, Corey Minyard wrote:
>
> If one of the OEM flags becomes set in the flags from the
> hardware, the driver could hang if no OEM handler was set.
> Fix the code to handle this. This was tested by setting
> the flags by hand after they were fetched.
>
> Signed-off-by: Corey Minyard <[email protected]>

Acked-by: Matt Domsch <[email protected]>

--
Matt Domsch
Software Architect
Dell Linux Solutions linux.dell.com & http://www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com