Subject: cachefiles on latest -mm fails to build on powerpc

currently on latest -mm, cachefiles fail to compile on powerpc
(ARCH=powerpc) at least:

MODPOST 592 modules
WARNING: "copy_page" [fs/cachefiles/cachefiles.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

config file attached

--
Aristeu

Attachments:
(No filename) (276.00 B)
 config (22.75 kB)
 Download all attachments

2006-09-15 13:51:21

by Frederik Deweerdt

[permalink] [raw]
Subject: Re: cachefiles on latest -mm fails to build on powerpc

On Fri, Sep 15, 2006 at 09:31:34AM -0300, Aristeu Sergio Rozanski Filho wrote:
> currently on latest -mm, cachefiles fail to compile on powerpc
> (ARCH=powerpc) at least:
>
> MODPOST 592 modules
> WARNING: "copy_page" [fs/cachefiles/cachefiles.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
>
> config file attached
>
Does the following patch help?

Thanks,
Frederik


diff --git a/include/linux/highmem.h b/include/linux/highmem.h
index b151c53..703dbaf 100644
--- a/include/linux/highmem.h
+++ b/include/linux/highmem.h
@@ -4,6 +4,7 @@ #define _LINUX_HIGHMEM_H
#include <linux/fs.h>
#include <linux/mm.h>

+#include <asm/page.h>
#include <asm/cacheflush.h>

#ifndef ARCH_HAS_FLUSH_ANON_PAGE

Subject: Re: cachefiles on latest -mm fails to build on powerpc

> Does the following patch help?
nope, it doesn't solve the problem :(
I'll rebuild everything just to make sure isn't anything build related

--
Aristeu

2006-09-15 15:36:46

by Frederik Deweerdt

[permalink] [raw]
Subject: Re: cachefiles on latest -mm fails to build on powerpc

On Fri, Sep 15, 2006 at 12:17:24PM -0300, Aristeu Sergio Rozanski Filho wrote:
> > Does the following patch help?
> nope, it doesn't solve the problem :(
> I'll rebuild everything just to make sure isn't anything build related
Err, my bad, is this one any better?

Regards,
Frederik

diff --git a/arch/powerpc/kernel/ppc_ksyms.c b/arch/powerpc/kernel/ppc_ksyms.c
index 39d3bfc..d6cc301 100644
--- a/arch/powerpc/kernel/ppc_ksyms.c
+++ b/arch/powerpc/kernel/ppc_ksyms.c
@@ -92,6 +92,8 @@ EXPORT_SYMBOL(__clear_user);
EXPORT_SYMBOL(__strncpy_from_user);
EXPORT_SYMBOL(__strnlen_user);

+EXPORT_SYMBOL(copy_page);
+
#ifndef __powerpc64__
EXPORT_SYMBOL(__ide_mm_insl);
EXPORT_SYMBOL(__ide_mm_outsw);

2006-09-15 15:39:40

by David Howells

[permalink] [raw]
Subject: Re: cachefiles on latest -mm fails to build on powerpc

Frederik Deweerdt <[email protected]> wrote:

> +EXPORT_SYMBOL(copy_page);

But only if !__powerpc64__. Otherwise you need copy_4K_page to be exported
instead.

David

2006-09-15 15:59:55

by Frederik Deweerdt

[permalink] [raw]
Subject: [-mm patch] add missing page_copy export for ppc and powerpc (was Re: cachefiles on latest -mm fails to build on powerpc)

On Fri, Sep 15, 2006 at 04:39:33PM +0100, David Howells wrote:
> Frederik Deweerdt <[email protected]> wrote:
>
> > +EXPORT_SYMBOL(copy_page);
>
> But only if !__powerpc64__. Otherwise you need copy_4K_page to be exported
> instead.
>
Oops, thanks, here's a corrected patch. From a quick look, it seems that
the ppc needs the same kind of export.
This adds a missing copy_page export for the powerpc and ppc arches.

Signed-off-by: Frederik Deweerdt <[email protected]>

diff --git a/arch/powerpc/kernel/ppc_ksyms.c b/arch/powerpc/kernel/ppc_ksyms.c
index 39d3bfc..23ccd5d 100644
--- a/arch/powerpc/kernel/ppc_ksyms.c
+++ b/arch/powerpc/kernel/ppc_ksyms.c
@@ -93,6 +93,12 @@ EXPORT_SYMBOL(__strncpy_from_user);
EXPORT_SYMBOL(__strnlen_user);

#ifndef __powerpc64__
+EXPORT_SYMBOL(copy_page);
+#else
+EXPORT_SYMBOL(copy_4K_page);
+#endif
+
+#ifndef __powerpc64__
EXPORT_SYMBOL(__ide_mm_insl);
EXPORT_SYMBOL(__ide_mm_outsw);
EXPORT_SYMBOL(__ide_mm_insw);
diff --git a/arch/ppc/kernel/ppc_ksyms.c b/arch/ppc/kernel/ppc_ksyms.c
index d173540..3045cc3 100644
--- a/arch/ppc/kernel/ppc_ksyms.c
+++ b/arch/ppc/kernel/ppc_ksyms.c
@@ -106,6 +106,8 @@ EXPORT_SYMBOL(__clear_user);
EXPORT_SYMBOL(__strncpy_from_user);
EXPORT_SYMBOL(__strnlen_user);

+EXPORT_SYMBOL(copy_page);
+
/*
EXPORT_SYMBOL(inb);
EXPORT_SYMBOL(inw);

Subject: Re: [-mm patch] add missing page_copy export for ppc and powerpc (was Re: cachefiles on latest -mm fails to build on powerpc)

> Oops, thanks, here's a corrected patch. From a quick look, it seems that
> the ppc needs the same kind of export.
> This adds a missing copy_page export for the powerpc and ppc arches.
this last patch solves the problem
>
> Signed-off-by: Frederik Deweerdt <[email protected]>
Acked-by: Aristeu S. Rozanski F. <[email protected]>

> diff --git a/arch/powerpc/kernel/ppc_ksyms.c b/arch/powerpc/kernel/ppc_ksyms.c
> index 39d3bfc..23ccd5d 100644
> --- a/arch/powerpc/kernel/ppc_ksyms.c
> +++ b/arch/powerpc/kernel/ppc_ksyms.c
> @@ -93,6 +93,12 @@ EXPORT_SYMBOL(__strncpy_from_user);
> EXPORT_SYMBOL(__strnlen_user);
>
> #ifndef __powerpc64__
> +EXPORT_SYMBOL(copy_page);
> +#else
> +EXPORT_SYMBOL(copy_4K_page);
> +#endif
> +
> +#ifndef __powerpc64__
> EXPORT_SYMBOL(__ide_mm_insl);
> EXPORT_SYMBOL(__ide_mm_outsw);
> EXPORT_SYMBOL(__ide_mm_insw);
> diff --git a/arch/ppc/kernel/ppc_ksyms.c b/arch/ppc/kernel/ppc_ksyms.c
> index d173540..3045cc3 100644
> --- a/arch/ppc/kernel/ppc_ksyms.c
> +++ b/arch/ppc/kernel/ppc_ksyms.c
> @@ -106,6 +106,8 @@ EXPORT_SYMBOL(__clear_user);
> EXPORT_SYMBOL(__strncpy_from_user);
> EXPORT_SYMBOL(__strnlen_user);
>
> +EXPORT_SYMBOL(copy_page);
> +
> /*
> EXPORT_SYMBOL(inb);
> EXPORT_SYMBOL(inw);
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>

--
Aristeu