Subject: [PATCH] ams: remove usage of input_dev cdev

This patch removes usage of 'cdev' member of input_dev, not present
on that struct anymore.

Signed-off-by: Aristeu S. Rozanski F. <[email protected]>

--- mm.orig/drivers/hwmon/ams/ams-mouse.c 2006-09-20 13:57:59.000000000 -0300
+++ mm/drivers/hwmon/ams/ams-mouse.c 2006-09-20 21:01:59.000000000 -0300
@@ -66,7 +66,6 @@
ams_info.idev->name = "Apple Motion Sensor";
ams_info.idev->id.bustype = ams_info.bustype;
ams_info.idev->id.vendor = 0;
- ams_info.idev->cdev.dev = &ams_info.of_dev->dev;

input_set_abs_params(ams_info.idev, ABS_X, -50, 50, 3, 0);
input_set_abs_params(ams_info.idev, ABS_Y, -50, 50, 3, 0);


2006-09-21 01:59:55

by Dmitry Torokhov

[permalink] [raw]
Subject: Re: [PATCH] ams: remove usage of input_dev cdev

On Wednesday 20 September 2006 20:51, Aristeu Sergio Rozanski Filho wrote:
> This patch removes usage of 'cdev' member of input_dev, not present
> on that struct anymore.
>

Where did it go?

> Signed-off-by: Aristeu S. Rozanski F. <[email protected]>
>
> --- mm.orig/drivers/hwmon/ams/ams-mouse.c 2006-09-20 13:57:59.000000000 -0300
> +++ mm/drivers/hwmon/ams/ams-mouse.c 2006-09-20 21:01:59.000000000 -0300
> @@ -66,7 +66,6 @@
> ams_info.idev->name = "Apple Motion Sensor";
> ams_info.idev->id.bustype = ams_info.bustype;
> ams_info.idev->id.vendor = 0;
> - ams_info.idev->cdev.dev = &ams_info.of_dev->dev;
>
> input_set_abs_params(ams_info.idev, ABS_X, -50, 50, 3, 0);
> input_set_abs_params(ams_info.idev, ABS_Y, -50, 50, 3, 0);
>

--
Dmitry

2006-09-21 02:13:53

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH] ams: remove usage of input_dev cdev

On Wed, 20 Sep 2006 21:59:53 -0400
Dmitry Torokhov <[email protected]> wrote:

> On Wednesday 20 September 2006 20:51, Aristeu Sergio Rozanski Filho wrote:
> > This patch removes usage of 'cdev' member of input_dev, not present
> > on that struct anymore.
> >
>
> Where did it go?

Sigh. That would make a good ./.signature

> > Signed-off-by: Aristeu S. Rozanski F. <[email protected]>
> >
> > --- mm.orig/drivers/hwmon/ams/ams-mouse.c 2006-09-20 13:57:59.000000000 -0300
> > +++ mm/drivers/hwmon/ams/ams-mouse.c 2006-09-20 21:01:59.000000000 -0300
> > @@ -66,7 +66,6 @@
> > ams_info.idev->name = "Apple Motion Sensor";
> > ams_info.idev->id.bustype = ams_info.bustype;
> > ams_info.idev->id.vendor = 0;
> > - ams_info.idev->cdev.dev = &ams_info.of_dev->dev;
> >
> > input_set_abs_params(ams_info.idev, ABS_X, -50, 50, 3, 0);
> > input_set_abs_params(ams_info.idev, ABS_Y, -50, 50, 3, 0);
> >

I think the right fix is s/cdev.dev/d.parent/g. But Greg has moved all
those patches out of the tree which I'll henceforth be merging into -mm, so
we can stop worrying about it.