2006-09-25 18:38:18

by Jeff Dike

[permalink] [raw]
Subject: [PATCH 6/8] UML - Add checkstack support

Make checkstack work for UML. We need to pass the underlying architecture
name, rather than "um" to checkstack.pl.

Signed-off-by: Jeff Dike <[email protected]>

Index: linux-2.6.18-mm/Makefile
===================================================================
--- linux-2.6.18-mm.orig/Makefile 2006-09-22 11:34:57.000000000 -0400
+++ linux-2.6.18-mm/Makefile 2006-09-22 11:35:38.000000000 -0400
@@ -1333,9 +1333,13 @@ endif #ifeq ($(config-targets),1)
endif #ifeq ($(mixed-targets),1)

PHONY += checkstack kernelrelease kernelversion
+
+# Use $(SUBARCH) here instead of $(ARCH) so that this works for UML.
+# In the UML case, $(SUBARCH) is the name of the underlying
+# architecture, while for all other arches, it is the same as $(ARCH).
checkstack:
$(OBJDUMP) -d vmlinux $$(find . -name '*.ko') | \
- $(PERL) $(src)/scripts/checkstack.pl $(ARCH)
+ $(PERL) $(src)/scripts/checkstack.pl $(SUBARCH)

kernelrelease:
$(if $(wildcard include/config/kernel.release), $(Q)echo $(KERNELRELEASE), \


2006-09-25 19:00:36

by Matt Mackall

[permalink] [raw]
Subject: Re: [PATCH 6/8] UML - Add checkstack support

On Mon, Sep 25, 2006 at 02:34:41PM -0400, Jeff Dike wrote:
> Make checkstack work for UML. We need to pass the underlying architecture
> name, rather than "um" to checkstack.pl.
>
> Signed-off-by: Jeff Dike <[email protected]>

Acked-by: Matt Mackall <[email protected]>

--
Mathematics is the supreme nostalgia of our time.

2006-09-26 09:28:59

by Jörn Engel

[permalink] [raw]
Subject: Re: [PATCH 6/8] UML - Add checkstack support

On Mon, 25 September 2006 13:58:52 -0500, Matt Mackall wrote:
> On Mon, Sep 25, 2006 at 02:34:41PM -0400, Jeff Dike wrote:
> > Make checkstack work for UML. We need to pass the underlying architecture
> > name, rather than "um" to checkstack.pl.
> >
> > Signed-off-by: Jeff Dike <[email protected]>
>
> Acked-by: Matt Mackall <[email protected]>
Acked-by: Joern Engel <[email protected]>

J?rn

--
Homo Sapiens is a goal, not a description.
-- unknown