2006-09-26 23:59:19

by Andrew Morton

Subject: Re: [PATCH] x86: Allow users to force a panic on NMI

On Tue, 26 Sep 2006 22:59:59 GMT
Linux Kernel Mailing List <[email protected]> wrote:

> --- a/kernel/panic.c
> +++ b/kernel/panic.c
> @@ -21,6 +21,7 @@ #include <linux/kexec.h>
> #include <linux/debug_locks.h>
>
> int panic_on_oops;
> +int panic_on_unrecovered_nmi;
> int tainted;
> static int pause_on_oops;
> static int pause_on_oops_flag;

Is visible to all architectures.

> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> index 040de6b..220e205 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -642,6 +642,14 @@ #if defined(CONFIG_X86_LOCAL_APIC) && de
> #endif
> #if defined(CONFIG_X86)
> {
> + .ctl_name = KERN_PANIC_ON_NMI,
> + .procname = "panic_on_unrecovered_nmi",
> + .data = &panic_on_unrecovered_nmi,
> + .maxlen = sizeof(int),
> + .mode = 0644,
> + .proc_handler = &proc_dointvec,
> + },
> + {

But is x86-only.

2006-09-27 07:41:09

by Andi Kleen

Subject: Re: [PATCH] x86: Allow users to force a panic on NMI

On Tue, Sep 26, 2006 at 04:58:57PM -0700, Andrew Morton wrote:
> On Tue, 26 Sep 2006 22:59:59 GMT
> Linux Kernel Mailing List <[email protected]> wrote:
>
> > --- a/kernel/panic.c
> > +++ b/kernel/panic.c
> > @@ -21,6 +21,7 @@ #include <linux/kexec.h>
> > #include <linux/debug_locks.h>
> >
> > int panic_on_oops;
> > +int panic_on_unrecovered_nmi;
> > int tainted;
> > static int pause_on_oops;
> > static int pause_on_oops_flag;
>
> Is visible to all architectures.

Ok, adding a #ifdef

-Andi