2006-10-03 12:32:55

by Karsten Wiese

Subject: [PATCH] Fix bug in snd-usb-usx2y's usX2Y_pcms_lock_check()

Fix bug in snd-usb-usx2y's usX2Y_pcms_lock_check()

substream can be NULL......
in mainline, bug was introduced by:
2006-06-22 [ALSA] Add O_APPEND flag support to PCM

Signed-off-by: Karsten Wiese <[email protected]>



--- alsa-kernel/usb/usx2y/usx2yhwdeppcm.c~ 2006-06-29 23:25:30.000000000 +0200
+++ alsa-kernel/usb/usx2y/usx2yhwdeppcm.c 2006-10-03 14:05:12.000000000 +0200
@@ -632,7 +632,7 @@ static int usX2Y_pcms_lock_check(struct
for (s = 0; s < 2; ++s) {
struct snd_pcm_substream *substream;
substream = pcm->streams[s].substream;
- if (SUBSTREAM_BUSY(substream))
+ if (substream && SUBSTREAM_BUSY(substream))
err = -EBUSY;
}
}

2006-10-04 15:25:05

by Takashi Iwai

Subject: Re: [PATCH] Fix bug in snd-usb-usx2y's usX2Y_pcms_lock_check()

At Tue, 3 Oct 2006 14:33:56 +0200,
Karsten Wiese wrote:
>
> Fix bug in snd-usb-usx2y's usX2Y_pcms_lock_check()
>
> substream can be NULL......
> in mainline, bug was introduced by:
> 2006-06-22 [ALSA] Add O_APPEND flag support to PCM
>
> Signed-off-by: Karsten Wiese <[email protected]>

Thanks, merged to ALSA tree.


Takashi