2006-10-09 03:07:29

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH] kernel-doc: drop __must_check and various "inline" qualifiers

From: Randy Dunlap <[email protected]>

Drop __inline, __always_inline, noinline, and __must_check in the
produced kernel-doc output, similar to other pseudo directives.

Signed-off-by: Randy Dunlap <[email protected]>
---
scripts/kernel-doc | 4 ++++
1 files changed, 4 insertions(+)

--- linux-2619-rc1g3.orig/scripts/kernel-doc
+++ linux-2619-rc1g3/scripts/kernel-doc
@@ -1518,7 +1518,11 @@ sub dump_function($$) {
$prototype =~ s/^asmlinkage +//;
$prototype =~ s/^inline +//;
$prototype =~ s/^__inline__ +//;
+ $prototype =~ s/^__inline +//;
+ $prototype =~ s/^__always_inline +//;
+ $prototype =~ s/^noinline +//;
$prototype =~ s/__devinit +//;
+ $prototype =~ s/__must_check +//;
$prototype =~ s/^#define +//; #ak added
$prototype =~ s/__attribute__ \(\([a-z,]*\)\)//;



---


2006-10-09 12:59:36

by Rolf Eike Beer

[permalink] [raw]
Subject: Re: [PATCH] kernel-doc: drop __must_check and various "inline" qualifiers

Randy Dunlap wrote:
> From: Randy Dunlap <[email protected]>
>
> Drop __inline, __always_inline, noinline, and __must_check in the
> produced kernel-doc output, similar to other pseudo directives.

The inline status of a function is not of much help for a developer, that's
right. But I would like to see the the __must_check in the documentation.
This it what makes a difference, the inline stuff is extraneous.

Eike

Attachments:
(No filename) (424.00 B)
 (No filename) (189.00 B)
 Download all attachments

2006-10-09 15:14:01

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH v2] kernel-doc: drop various "inline" qualifiers

On Mon, 9 Oct 2006 15:00:18 +0200 Rolf Eike Beer wrote:

> The inline status of a function is not of much help for a developer, that's
> right. But I would like to see the the __must_check in the documentation.
> This it what makes a difference, the inline stuff is extraneous.

---
From: Randy Dunlap <[email protected]>

Drop __inline, __always_inline, and noinline in the
produced kernel-doc output, similar to other pseudo directives.

Signed-off-by: Randy Dunlap <[email protected]>
---
scripts/kernel-doc | 3 +++
1 files changed, 3 insertions(+)

--- linux-2619-rc1g3.orig/scripts/kernel-doc
+++ linux-2619-rc1g3/scripts/kernel-doc
@@ -1518,6 +1518,9 @@ sub dump_function($$) {
$prototype =~ s/^asmlinkage +//;
$prototype =~ s/^inline +//;
$prototype =~ s/^__inline__ +//;
+ $prototype =~ s/^__inline +//;
+ $prototype =~ s/^__always_inline +//;
+ $prototype =~ s/^noinline +//;
$prototype =~ s/__devinit +//;
$prototype =~ s/^#define +//; #ak added
$prototype =~ s/__attribute__ \(\([a-z,]*\)\)//;