2006-10-10 06:00:19

by Noguchi, Masato

Subject: RE: [Cbe-oss-dev] [PATCH 09/14] spufs: add support for read/write oncntl

After applying these patches, it seems the kernel leaks memory.
No doubt you forget to call simple_attr_close on "[PATCH 09/14]
spufs: add support for read/write oncntl".

Signed-off-by: Masato Noguchi <[email protected]>

---

Index:
linux-2.6.18-arnd-20061004/arch/powerpc/platforms/cell/spufs/file.c
===================================================================
---
linux-2.6.18-arnd-20061004.orig/arch/powerpc/platforms/cell/spufs/file.c
+++ linux-2.6.18-arnd-20061004/arch/powerpc/platforms/cell/spufs/file.c
@@ -246,6 +246,7 @@ static int spufs_cntl_open(struct inode

static struct file_operations spufs_cntl_fops = {
.open = spufs_cntl_open,
+ .close = simple_attr_close,
.read = simple_attr_read,
.write = simple_attr_write,
.mmap = spufs_cntl_mmap,

2006-10-10 08:11:36

by Arnd Bergmann

Subject: Re: [Cbe-oss-dev] [PATCH 09/14] spufs: add support for read/write oncntl

On Tuesday 10 October 2006 08:00, Noguchi, Masato wrote:
> After applying these patches, it seems the kernel leaks memory.
> No doubt you forget to call simple_attr_close on "[PATCH 09/14]
> spufs: add support for read/write oncntl".

Ok, thanks for pointing this out.

> Signed-off-by: Masato Noguchi <[email protected]>
Signed-off-by: Arnd Bergmann <[email protected]>

Paul, please apply.

Arnd <><