2006-10-10 06:49:12

by Noguchi, Masato

Subject: RE: [Cbe-oss-dev] [PATCH 09/14] spufs: add support for read/write oncntl

Oops,
I'm so sorry. I mistake to send wrong patch.
Correct version is below:

Signed-off-by: Masato Noguchi <[email protected]>

---

Index:
linux-2.6.18-arnd-20061004/arch/powerpc/platforms/cell/spufs/file.c
===================================================================
---
linux-2.6.18-arnd-20061004.orig/arch/powerpc/platforms/cell/spufs/file.c
+++ linux-2.6.18-arnd-20061004/arch/powerpc/platforms/cell/spufs/file.c
@@ -246,6 +246,7 @@ static int spufs_cntl_open(struct inode

static struct file_operations spufs_cntl_fops = {
.open = spufs_cntl_open,
+ .release = simple_attr_close,
.read = simple_attr_read,
.write = simple_attr_write,
.mmap = spufs_cntl_mmap,


> -----Original Message-----
> From: Noguchi, Masato
> Sent: Tuesday, October 10, 2006 3:00 PM
> To: 'Arnd Bergmann'
> Cc: Paul Mackerras; Arnd Bergmann; [email protected];
> [email protected]; [email protected]
> Subject: RE: [Cbe-oss-dev] [PATCH 09/14] spufs: add support for
read/write
> oncntl
>
> After applying these patches, it seems the kernel leaks memory.
> No doubt you forget to call simple_attr_close on "[PATCH 09/14]
> spufs: add support for read/write oncntl".
>
> Signed-off-by: Masato Noguchi <[email protected]>
>
> ---
>
> Index:
linux-2.6.18-arnd-20061004/arch/powerpc/platforms/cell/spufs/file.c
> ===================================================================
> ---
>
linux-2.6.18-arnd-20061004.orig/arch/powerpc/platforms/cell/spufs/file.c
> +++
linux-2.6.18-arnd-20061004/arch/powerpc/platforms/cell/spufs/file.c
> @@ -246,6 +246,7 @@ static int spufs_cntl_open(struct inode
>
> static struct file_operations spufs_cntl_fops = {
> .open = spufs_cntl_open,
> + .close = simple_attr_close,
> .read = simple_attr_read,
> .write = simple_attr_write,
> .mmap = spufs_cntl_mmap,
>

2006-10-10 08:28:17

by Arnd Bergmann

Subject: [PATCH] spufs: fix support for read/write on cntl

From: "Noguchi, Masato" <[email protected]>

This fixes a memory leak introduced by "spufs: add support
for read/write oncntl", which was missing a call to simple_attr_close.

Signed-off-by: Masato Noguchi <[email protected]>
Signed-off-by: Arnd Bergmann <[email protected]>

---

On Tuesday 10 October 2006 08:49, Noguchi, Masato wrote:
> Oops,
> I'm so sorry. I mistake to send wrong patch.

Ok, no worries. Paul, please use this patch instead.

Index: linux-2.6/arch/powerpc/platforms/cell/spufs/file.c
===================================================================
--- linux-2.6.orig/arch/powerpc/platforms/cell/spufs/file.c
+++ linux-2.6/arch/powerpc/platforms/cell/spufs/file.c
@@ -246,6 +246,7 @@ static int spufs_cntl_open(struct inode

static struct file_operations spufs_cntl_fops = {
.open = spufs_cntl_open,
+ .release = simple_attr_close,
.read = simple_attr_read,
.write = simple_attr_write,
.mmap = spufs_cntl_mmap,