2006-10-23 01:45:07

by Alistair John Strachan

[permalink] [raw]
Subject: 2.6.19-rc2: ieee80211/ipw2200 regression

Hi,

I just tried 2.6.19-rc2 on my HP NC6000 and I'm getting bizarre messages to
dmesg:

ipw2200: Intel(R) PRO/Wireless 2200/2915 Network Driver, 1.1.4km
ipw2200: Copyright(c) 2003-2006 Intel Corporation
ACPI: PCI Interrupt 0000:02:04.0[A] -> Link [C0C6] -> GSI 11 (level, low) ->
IRQ 11
ipw2200: Detected Intel PRO/Wireless 2200BG Network Connection
ipw2200: Detected geography ZZR (14 802.11bg channels, 0 802.11a channels)
ieee80211_crypt_wep: could not allocate crypto API arc4
wlan: could not initialize WEP: load module ieee80211_crypt_wep

[alistair] 02:42 [~/linux-git] cat /boot/System.map-`uname -r` | grep arc4
c01f7970 t arc4_crypt
c01f7a10 t arc4_set_key
c0341be0 d arc4_alg
c0390cc0 t arc4_init
c03a393c t __initcall_arc4_init
c03a6380 t arc4_exit

ARC4 is compiled in (i.e., not a module), find my config attached. Only
happens after I try to pass the driver a WEP key with iwconfig wlan key
<blah>. Any ideas?

All of this worked fine on 2.6.18.

--
Cheers,
Alistair.

Final year Computer Science undergraduate.
1F2 55 South Clerk Street, Edinburgh, UK.


Attachments:
(No filename) (1.05 kB)
config-2.6.19-rc2 (41.32 kB)
Download all attachments

2006-10-23 03:45:27

by Zhu Yi

[permalink] [raw]
Subject: Re: 2.6.19-rc2: ieee80211/ipw2200 regression

On Mon, 2006-10-23 at 02:44 +0100, Alistair John Strachan wrote:
> [alistair] 02:42 [~/linux-git] cat /boot/System.map-`uname -r` | grep
> arc4
> c01f7970 t arc4_crypt
> c01f7a10 t arc4_set_key
> c0341be0 d arc4_alg
> c0390cc0 t arc4_init
> c03a393c t __initcall_arc4_init
> c03a6380 t arc4_exit

It should be OK if you configured ARC4 and CRC32 in kernel. Can you also
see the symbols in /proc/kallsyms? (In case /boot/System.map-`uname -r`
differs with the currently running kernel.)

Thanks,
-yi

2006-10-23 13:22:09

by Alistair John Strachan

[permalink] [raw]
Subject: Re: 2.6.19-rc2: ieee80211/ipw2200 regression

On Monday 23 October 2006 04:42, Zhu Yi wrote:
> On Mon, 2006-10-23 at 02:44 +0100, Alistair John Strachan wrote:
> > [alistair] 02:42 [~/linux-git] cat /boot/System.map-`uname -r` | grep
> > arc4
> > c01f7970 t arc4_crypt
> > c01f7a10 t arc4_set_key
> > c0341be0 d arc4_alg
> > c0390cc0 t arc4_init
> > c03a393c t __initcall_arc4_init
> > c03a6380 t arc4_exit
>
> It should be OK if you configured ARC4 and CRC32 in kernel. Can you also
> see the symbols in /proc/kallsyms? (In case /boot/System.map-`uname -r`
> differs with the currently running kernel.)

You're right, they're not there. However the files were built at the same
time!

[alistair] 14:20 [~] ls -lah /boot/*2.6.19-rc2*
-rw-r--r-- 1 root root 36K 2006-10-13 21:46 /boot/config-2.6.19-rc2
-rw-r--r-- 1 root root 798K 2006-10-13 21:46 /boot/System.map-2.6.19-rc2
-rw-r--r-- 1 root root 1.7M 2006-10-13 21:46 /boot/vmlinuz-2.6.19-rc2

Maybe it's a problem with the crypto subsystem?

--
Cheers,
Alistair.

Final year Computer Science undergraduate.
1F2 55 South Clerk Street, Edinburgh, UK.

2006-10-23 13:54:04

by Alistair John Strachan

[permalink] [raw]
Subject: Re: 2.6.19-rc2: ieee80211/ipw2200 regression

On Monday 23 October 2006 14:22, Alistair John Strachan wrote:
> On Monday 23 October 2006 04:42, Zhu Yi wrote:
> > On Mon, 2006-10-23 at 02:44 +0100, Alistair John Strachan wrote:
> > > [alistair] 02:42 [~/linux-git] cat /boot/System.map-`uname -r` | grep
> > > arc4
> > > c01f7970 t arc4_crypt
> > > c01f7a10 t arc4_set_key
> > > c0341be0 d arc4_alg
> > > c0390cc0 t arc4_init
> > > c03a393c t __initcall_arc4_init
> > > c03a6380 t arc4_exit
> >
> > It should be OK if you configured ARC4 and CRC32 in kernel. Can you also
> > see the symbols in /proc/kallsyms? (In case /boot/System.map-`uname -r`
> > differs with the currently running kernel.)
>
> You're right, they're not there. However the files were built at the same
> time!

Actually, sorry, I was looking at the wrong machine. They are indeed there:

[alistair] 14:20 [~] cat /proc/kallsyms | grep arc4

c01f7970 t arc4_crypt
c01f7a10 t arc4_set_key
c0390cc0 t arc4_init

>
> [alistair] 14:20 [~] ls -lah /boot/*2.6.19-rc2*
> -rw-r--r-- 1 root root 36K 2006-10-13 21:46 /boot/config-2.6.19-rc2
> -rw-r--r-- 1 root root 798K 2006-10-13 21:46 /boot/System.map-2.6.19-rc2
> -rw-r--r-- 1 root root 1.7M 2006-10-13 21:46 /boot/vmlinuz-2.6.19-rc2
>
> Maybe it's a problem with the crypto subsystem?

--
Cheers,
Alistair.

Final year Computer Science undergraduate.
1F2 55 South Clerk Street, Edinburgh, UK.

2006-10-23 15:35:51

by Alistair John Strachan

[permalink] [raw]
Subject: Re: 2.6.19-rc2: ieee80211/ipw2200 regression

On Monday 23 October 2006 14:54, Alistair John Strachan wrote:
> On Monday 23 October 2006 14:22, Alistair John Strachan wrote:
> > On Monday 23 October 2006 04:42, Zhu Yi wrote:
> > > On Mon, 2006-10-23 at 02:44 +0100, Alistair John Strachan wrote:
> > > > [alistair] 02:42 [~/linux-git] cat /boot/System.map-`uname -r` | grep
> > > > arc4
> > > > c01f7970 t arc4_crypt
> > > > c01f7a10 t arc4_set_key
> > > > c0341be0 d arc4_alg
> > > > c0390cc0 t arc4_init
> > > > c03a393c t __initcall_arc4_init
> > > > c03a6380 t arc4_exit
> > >
> > > It should be OK if you configured ARC4 and CRC32 in kernel. Can you
> > > also see the symbols in /proc/kallsyms? (In case
> > > /boot/System.map-`uname -r` differs with the currently running kernel.)
> >
> > You're right, they're not there. However the files were built at the same
> > time!
>
> Actually, sorry, I was looking at the wrong machine. They are indeed there:
>
> [alistair] 14:20 [~] cat /proc/kallsyms | grep arc4
>
> c01f7970 t arc4_crypt
> c01f7a10 t arc4_set_key
> c0390cc0 t arc4_init

Tried compiling as a module too and the ieee80211 system doesn't load arc4.ko
before bailing out. If I reboot, load it myself and try again, it still
doesn't work.

--
Cheers,
Alistair.

Final year Computer Science undergraduate.
1F2 55 South Clerk Street, Edinburgh, UK.

2006-10-23 15:45:44

by Patrick McHardy

[permalink] [raw]
Subject: Re: 2.6.19-rc2: ieee80211/ipw2200 regression

diff --git a/net/ieee80211/Kconfig b/net/ieee80211/Kconfig
index f7e84e9..dbf55d3 100644
--- a/net/ieee80211/Kconfig
+++ b/net/ieee80211/Kconfig
@@ -32,6 +32,7 @@ config IEEE80211_CRYPT_WEP
depends on IEEE80211
select CRYPTO
select CRYPTO_ARC4
+ select CRYPTO_ECB
select CRC32
---help---
Include software based cipher suites in support of IEEE


Attachments:
x (356.00 B)

2006-10-23 15:53:47

by Alistair John Strachan

[permalink] [raw]
Subject: Re: 2.6.19-rc2: ieee80211/ipw2200 regression

On Monday 23 October 2006 16:45, Patrick McHardy wrote:
> Alistair John Strachan wrote:
> > Tried compiling as a module too and the ieee80211 system doesn't load
> > arc4.ko before bailing out. If I reboot, load it myself and try again, it
> > still doesn't work.
>
> Do you have CONFIG_CRYPTO_ECB enabled? I think this patch is needed.

Good catch, I did need this and it wasn't enabled.

Thanks Patrick. From a quick grep of the tree for ecb(, I think
CONFIG_PPP_MPPE and IEEE80211_CRYPT_TKIP will also need a similar patch.

--
Cheers,
Alistair.

Final year Computer Science undergraduate.
1F2 55 South Clerk Street, Edinburgh, UK.

2006-10-23 16:03:16

by Alistair John Strachan

[permalink] [raw]
Subject: Re: 2.6.19-rc2: ieee80211/ipw2200 regression

On Monday 23 October 2006 16:53, Alistair John Strachan wrote:
> On Monday 23 October 2006 16:45, Patrick McHardy wrote:
> > Alistair John Strachan wrote:
> > > Tried compiling as a module too and the ieee80211 system doesn't load
> > > arc4.ko before bailing out. If I reboot, load it myself and try again,
> > > it still doesn't work.
> >
> > Do you have CONFIG_CRYPTO_ECB enabled? I think this patch is needed.
>
> Good catch, I did need this and it wasn't enabled.
>
> Thanks Patrick. From a quick grep of the tree for ecb(, I think
> CONFIG_PPP_MPPE and IEEE80211_CRYPT_TKIP will also need a similar patch.

Patrick, these also need CRYPTO_MANAGER, or it still doesn't work. With
CRYPTO_MANAGER, CRYPTO_ECB and CRYPTO_ARC4, ieee80211 WEP starts working
again.

--
Cheers,
Alistair.

Final year Computer Science undergraduate.
1F2 55 South Clerk Street, Edinburgh, UK.

2006-10-23 16:09:14

by Patrick McHardy

[permalink] [raw]
Subject: Re: 2.6.19-rc2: ieee80211/ipw2200 regression

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index e2ed249..e38846e 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2717,6 +2717,7 @@ config PPP_MPPE
select CRYPTO
select CRYPTO_SHA1
select CRYPTO_ARC4
+ select CRYPTO_ECB
---help---
Support for the MPPE Encryption protocol, as employed by the
Microsoft Point-to-Point Tunneling Protocol.
diff --git a/fs/Kconfig b/fs/Kconfig
index fee318e..133dcc8 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -1777,6 +1777,7 @@ config RPCSEC_GSS_KRB5
select CRYPTO
select CRYPTO_MD5
select CRYPTO_DES
+ select CRYPTO_CBC
help
Provides for secure RPC calls by means of a gss-api
mechanism based on Kerberos V5. This is required for
@@ -1795,6 +1796,7 @@ config RPCSEC_GSS_SPKM3
select CRYPTO_MD5
select CRYPTO_DES
select CRYPTO_CAST5
+ select CRYPTO_CBC
help
Provides for secure RPC calls by means of a gss-api
mechanism based on the SPKM3 public-key mechanism.
diff --git a/net/ieee80211/Kconfig b/net/ieee80211/Kconfig
index f7e84e9..a64be6c 100644
--- a/net/ieee80211/Kconfig
+++ b/net/ieee80211/Kconfig
@@ -32,6 +32,7 @@ config IEEE80211_CRYPT_WEP
depends on IEEE80211
select CRYPTO
select CRYPTO_ARC4
+ select CRYPTO_ECB
select CRC32
---help---
Include software based cipher suites in support of IEEE
@@ -58,6 +59,7 @@ config IEEE80211_CRYPT_TKIP
depends on IEEE80211 && NET_RADIO
select CRYPTO
select CRYPTO_MICHAEL_MIC
+ select CRYPTO_ECB
select CRC32
---help---
Include software based cipher suites in support of IEEE 802.11i


Attachments:
x (1.56 kB)

2006-10-23 22:34:29

by Herbert Xu

[permalink] [raw]
Subject: Re: 2.6.19-rc2: ieee80211/ipw2200 regression

On Mon, Oct 23, 2006 at 06:09:08PM +0200, Patrick McHardy wrote:
>
> I've added CONFIG_ECB to the ones you mentioned and CONFIG_CBC to
> gssapi.
>
> Signed-off-by: Patrick McHardy <[email protected]>

Thanks a lot Patrick! I'll put this into crypto-2.6.
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt