2006-11-01 05:34:49

by Chris Wright

[permalink] [raw]
Subject: [PATCH 02/61] splice: fix pipe_to_file() ->prepare_write() error path

-stable review patch. If anyone has any objections, please let us know.
------------------

From: Jens Axboe <[email protected]>

Don't jump to the unlock+release path, we already did that.

Signed-off-by: Jens Axboe <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Chris Wright <[email protected]>

---
fs/splice.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

--- linux-2.6.18.1.orig/fs/splice.c
+++ linux-2.6.18.1/fs/splice.c
@@ -607,7 +607,7 @@ find_page:
ret = -ENOMEM;
page = page_cache_alloc_cold(mapping);
if (unlikely(!page))
- goto out_nomem;
+ goto out_ret;

/*
* This will also lock the page
@@ -666,7 +666,7 @@ find_page:
if (sd->pos + this_len > isize)
vmtruncate(mapping->host, isize);

- goto out;
+ goto out_ret;
}

if (buf->page != page) {
@@ -698,7 +698,7 @@ find_page:
out:
page_cache_release(page);
unlock_page(page);
-out_nomem:
+out_ret:
return ret;
}


--