2006-11-03 07:00:41

by Ankita Garg

[permalink] [raw]
Subject: [PATCH] Fix for LKDTM MEM_SWAPOUT crashpoint

Hi,

The MEM_SWAPOUT crashpoint in LKDTM could be broken as some compilers inline the call to shrink_page_list() and symbol lookup for this function name fails.
Replacing it with the function shrink_inactive_list(), which is the only
function calling shrink_page_list().

Regards,
--
Ankita Garg ([email protected])
Linux Technology Center
IBM India Systems & Technology Labs,
Bangalore, India


Attachments:
(No filename) (402.00 B)
lkdtm-mem-swapout-fix.patch (1.24 kB)
Download all attachments

2006-11-03 10:39:15

by Ankita Garg

[permalink] [raw]
Subject: Re: [PATCH] Fix for LKDTM MEM_SWAPOUT crashpoint

Hi,

Re-posting the patch to fix up the MEM_SWAPOUT crashpoint (after fixing
a typo).

o Fix for MEM_SWAPOUT crashpoint as some compilers inline the call to
shrink_page_list() and symbol lookup for this function name fails.

Signed-off-by: Ankita Garg <[email protected]>
---
lkdtm.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

Index: linux-2.6.19-rc4/drivers/misc/lkdtm.c
===================================================================
--- linux-2.6.19-rc4.orig/drivers/misc/lkdtm.c 2006-11-03 11:41:50.000000000 +0530
+++ linux-2.6.19-rc4/drivers/misc/lkdtm.c 2006-11-03 11:46:36.000000000 +0530
@@ -157,8 +157,8 @@

struct scan_control;

-unsigned long jp_shrink_page_list(struct list_head *page_list,
- struct scan_control *sc)
+unsigned long jp_shrink_inactive_list(unsigned long max_scan,
+ struct zone *zone, struct scan_control *sc)
{
lkdtm_handler();
jprobe_return();
@@ -297,8 +297,8 @@
lkdtm.entry = (kprobe_opcode_t*) jp_ll_rw_block;
break;
case MEM_SWAPOUT:
- lkdtm.kp.symbol_name = "shrink_page_list";
- lkdtm.entry = (kprobe_opcode_t*) jp_shrink_page_list;
+ lkdtm.kp.symbol_name = "shrink_inactive_list";
+ lkdtm.entry = (kprobe_opcode_t*) jp_shrink_inactive_list;
break;
case TIMERADD:
lkdtm.kp.symbol_name = "hrtimer_start";


Regards,
--
Ankita Garg ([email protected])
Linux Technology Center
IBM India Systems & Technology Labs,
Bangalore, India