2006-11-13 08:15:23

by Dennis Stosberg

Subject: [PATCH] aoe: Add forgotten NULL at end of attribute list in aoeblk.c

This caused the system to stall when the aoe module was loaded. The
error was introduced in commit 4ca5224f3ea4779054d96e885ca9b3980801ce13

Signed-off-by: Dennis Stosberg <[email protected]>
---

The log of the caused error can be found at
http://stosberg.net/tmp/aoe_trace.txt

drivers/block/aoe/aoeblk.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/block/aoe/aoeblk.c b/drivers/block/aoe/aoeblk.c
index d433f27..aa25f8b 100644
--- a/drivers/block/aoe/aoeblk.c
+++ b/drivers/block/aoe/aoeblk.c
@@ -68,6 +68,7 @@ static struct attribute *aoe_attrs[] = {
&disk_attr_mac.attr,
&disk_attr_netif.attr,
&disk_attr_fwver.attr,
+ NULL
};

static const struct attribute_group attr_group = {
--
1.4.3.3

2006-11-16 16:24:41

by Ed L. Cashin

Subject: Re: [PATCH] aoe: Add forgotten NULL at end of attribute list in aoeblk.c

On Mon, Nov 13, 2006 at 09:15:20AM +0100, Dennis Stosberg wrote:
> This caused the system to stall when the aoe module was loaded. The
> error was introduced in commit 4ca5224f3ea4779054d96e885ca9b3980801ce13

Boy, I've been totally spoiled by the gitweb at kernel.org. It's been
unavailable lately.

Anyway, thanks for the fix. It looks good to me if it looks good to
Greg---after a google search it appears that your patch is a followup
to his consolidation of the attributes.

> Signed-off-by: Dennis Stosberg <[email protected]>
> ---
>
> The log of the caused error can be found at
> http://stosberg.net/tmp/aoe_trace.txt
>
> drivers/block/aoe/aoeblk.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/block/aoe/aoeblk.c b/drivers/block/aoe/aoeblk.c
> index d433f27..aa25f8b 100644
> --- a/drivers/block/aoe/aoeblk.c
> +++ b/drivers/block/aoe/aoeblk.c
> @@ -68,6 +68,7 @@ static struct attribute *aoe_attrs[] = {
> &disk_attr_mac.attr,
> &disk_attr_netif.attr,
> &disk_attr_fwver.attr,
> + NULL
> };
>
> static const struct attribute_group attr_group = {
> --
> 1.4.3.3

--
Ed L Cashin <[email protected]>