2006-11-15 11:51:06

by Alexey Dobriyan

Subject: [PATCH] Don't give bad kprobes example aka ") < 0))" typo

Signed-off-by: Alexey Dobriyan <[email protected]>
---

Documentation/kprobes.txt | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

--- a/Documentation/kprobes.txt
+++ b/Documentation/kprobes.txt
@@ -442,9 +442,10 @@ static int __init kprobe_init(void)
kp.fault_handler = handler_fault;
kp.symbol_name = "do_fork";

- if ((ret = register_kprobe(&kp) < 0)) {
+ ret = register_kprobe(&kp);
+ if (ret < 0) {
printk("register_kprobe failed, returned %d\n", ret);
- return -1;
+ return ret;
}
printk("kprobe registered\n");
return 0;

2006-11-15 11:57:19

by Christoph Hellwig

Subject: Re: [PATCH] Don't give bad kprobes example aka ") < 0))" typo

On Wed, Nov 15, 2006 at 06:56:19PM +0300, Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <[email protected]>
> ---
>
> Documentation/kprobes.txt | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> --- a/Documentation/kprobes.txt
> +++ b/Documentation/kprobes.txt
> @@ -442,9 +442,10 @@ static int __init kprobe_init(void)
> kp.fault_handler = handler_fault;
> kp.symbol_name = "do_fork";
>
> - if ((ret = register_kprobe(&kp) < 0)) {
> + ret = register_kprobe(&kp);
> + if (ret < 0) {
> printk("register_kprobe failed, returned %d\n", ret);
> - return -1;
> + return ret;

This looks good, thanks.