From: Jay Cliburn <[email protected]>
This patch contains the build files for the Attansic L1 gigabit ethernet
adapter driver.
Signed-off-by: Jay Cliburn <[email protected]>
---
Kconfig | 12 ++++++++++++
Makefile | 1 +
atl1/Makefile | 30 ++++++++++++++++++++++++++++++
3 files changed, 43 insertions(+)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 6e863aa..f503d10 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2329,6 +2329,18 @@ config QLA3XXX
To compile this driver as a module, choose M here: the module
will be called qla3xxx.
+config ATL1
+ tristate "Attansic(R) L1 Gigabit Ethernet support (EXPERIMENTAL)"
+ depends on NET_PCI && PCI && EXPERIMENTAL
+ select CRC32
+ select MII
+ ---help---
+ This driver supports Attansic L1 gigabit ethernet adapter.
+
+ To compile this driver as a module, choose M here. The module
+ will be called atl1.
+
+
endmenu
#
diff --git a/drivers/net/Makefile b/drivers/net/Makefile
index f270bc4..b839af8 100644
--- a/drivers/net/Makefile
+++ b/drivers/net/Makefile
@@ -8,6 +8,7 @@ obj-$(CONFIG_IXGB) += ixgb/
obj-$(CONFIG_CHELSIO_T1) += chelsio/
obj-$(CONFIG_EHEA) += ehea/
obj-$(CONFIG_BONDING) += bonding/
+obj-$(CONFIG_ATL1) += atl1/
obj-$(CONFIG_GIANFAR) += gianfar_driver.o
gianfar_driver-objs := gianfar.o \
diff --git a/drivers/net/atl1/Makefile b/drivers/net/atl1/Makefile
new file mode 100644
index 0000000..1a10b91
--- /dev/null
+++ b/drivers/net/atl1/Makefile
@@ -0,0 +1,30 @@
+################################################################################
+#
+# Attansic L1 gigabit ethernet driver
+# Copyright(c) 2005 - 2006 Attansic Corporation.
+#
+# This program is free software; you can redistribute it and/or modify it
+# under the terms and conditions of the GNU General Public License,
+# version 2, as published by the Free Software Foundation.
+#
+# This program is distributed in the hope it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
+# more details.
+#
+# You should have received a copy of the GNU General Public License along with
+# this program; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
+#
+# The full GNU General Public License is included in this distribution in
+# the file called "COPYING".
+#
+################################################################################
+
+#
+# Makefile for the Attansic L1 gigabit ethernet driver
+#
+
+obj-$(CONFIG_ATL1) += atl1.o
+
+atl1-objs := atl1_main.o atl1_hw.o atl1_ethtool.o atl1_param.o
On Sun, 19 Nov 2006 14:29:15 -0600 Jay Cliburn wrote:
> From: Jay Cliburn <[email protected]>
>
> This patch contains the build files for the Attansic L1 gigabit ethernet
> adapter driver.
>
> Signed-off-by: Jay Cliburn <[email protected]>
> ---
>
> Kconfig | 12 ++++++++++++
> Makefile | 1 +
> atl1/Makefile | 30 ++++++++++++++++++++++++++++++
> 3 files changed, 43 insertions(+)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 6e863aa..f503d10 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2329,6 +2329,18 @@ config QLA3XXX
> To compile this driver as a module, choose M here: the module
> will be called qla3xxx.
>
> +config ATL1
> + tristate "Attansic(R) L1 Gigabit Ethernet support (EXPERIMENTAL)"
> + depends on NET_PCI && PCI && EXPERIMENTAL
> + select CRC32
> + select MII
> + ---help---
> + This driver supports Attansic L1 gigabit ethernet adapter.
> +
> + To compile this driver as a module, choose M here. The module
> + will be called atl1.
> +
> +
> endmenu
One problem here is that MII depends on NET_ETHERNET, which is
10/100 ethernet, which may not be enabled if someone has only
gigabit ethernet. :)
I have a partial patch which moves MII and PHYLIB outside of
NET_ETHERNET. That also makes them usable by USB or other
non-drivers/net/ drivers, e.g., again without the need
to enable NET_ETHERNET if someone only has USB ethernet. :(
I'll try to post it for review later today.
---
~Randy
Randy Dunlap wrote:
> On Sun, 19 Nov 2006 14:29:15 -0600 Jay Cliburn wrote:
>
>> From: Jay Cliburn <[email protected]>
>>
>> This patch contains the build files for the Attansic L1 gigabit ethernet
>> adapter driver.
>>
>> Signed-off-by: Jay Cliburn <[email protected]>
>> ---
>>
>> Kconfig | 12 ++++++++++++
>> Makefile | 1 +
>> atl1/Makefile | 30 ++++++++++++++++++++++++++++++
>> 3 files changed, 43 insertions(+)
>>
>> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
>> index 6e863aa..f503d10 100644
>> --- a/drivers/net/Kconfig
>> +++ b/drivers/net/Kconfig
>> @@ -2329,6 +2329,18 @@ config QLA3XXX
>> To compile this driver as a module, choose M here: the module
>> will be called qla3xxx.
>>
>> +config ATL1
>> + tristate "Attansic(R) L1 Gigabit Ethernet support (EXPERIMENTAL)"
>> + depends on NET_PCI && PCI && EXPERIMENTAL
>> + select CRC32
>> + select MII
>> + ---help---
>> + This driver supports Attansic L1 gigabit ethernet adapter.
>> +
>> + To compile this driver as a module, choose M here. The module
>> + will be called atl1.
>> +
>> +
>> endmenu
>
> One problem here is that MII depends on NET_ETHERNET, which is
> 10/100 ethernet, which may not be enabled if someone has only
> gigabit ethernet. :)
I'm actually quite inclined to rip out all MII support entirely.
There's a lot of code in this driver that needs cleaning up
cosmetically, and removing deprecated features would certainly speed
things up. What do you think?
-- Chris
Chris Snook wrote:
> Randy Dunlap wrote:
>> On Sun, 19 Nov 2006 14:29:15 -0600 Jay Cliburn wrote:
>>
>>> From: Jay Cliburn <[email protected]>
>>>
>>> This patch contains the build files for the Attansic L1 gigabit ethernet
>>> adapter driver.
>>>
>>> Signed-off-by: Jay Cliburn <[email protected]>
>>> ---
>>>
>>> Kconfig | 12 ++++++++++++
>>> Makefile | 1 +
>>> atl1/Makefile | 30 ++++++++++++++++++++++++++++++
>>> 3 files changed, 43 insertions(+)
>>>
>>> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
>>> index 6e863aa..f503d10 100644
>>> --- a/drivers/net/Kconfig
>>> +++ b/drivers/net/Kconfig
>>> @@ -2329,6 +2329,18 @@ config QLA3XXX
>>> To compile this driver as a module, choose M here: the module
>>> will be called qla3xxx.
>>>
>>> +config ATL1
>>> + tristate "Attansic(R) L1 Gigabit Ethernet support (EXPERIMENTAL)"
>>> + depends on NET_PCI && PCI && EXPERIMENTAL
>>> + select CRC32
>>> + select MII
>>> + ---help---
>>> + This driver supports Attansic L1 gigabit ethernet adapter.
>>> +
>>> + To compile this driver as a module, choose M here. The module
>>> + will be called atl1.
>>> +
>>> +
>>> endmenu
>>
>> One problem here is that MII depends on NET_ETHERNET, which is
>> 10/100 ethernet, which may not be enabled if someone has only
>> gigabit ethernet. :)
>
> I'm actually quite inclined to rip out all MII support entirely. There's
> a lot of code in this driver that needs cleaning up cosmetically, and
> removing deprecated features would certainly speed things up. What do
> you think?
All of that sounds like a good idea to me.
I didn't realize that MII support is deprecated. Do you mean
that it's deprecated for gigabit?
--
~Randy
Randy Dunlap wrote:
> Chris Snook wrote:
>> Randy Dunlap wrote:
>>> On Sun, 19 Nov 2006 14:29:15 -0600 Jay Cliburn wrote:
>>>
>>>> From: Jay Cliburn <[email protected]>
>>>>
>>>> This patch contains the build files for the Attansic L1 gigabit
>>>> ethernet
>>>> adapter driver.
>>>>
>>>> Signed-off-by: Jay Cliburn <[email protected]>
>>>> ---
>>>>
>>>> Kconfig | 12 ++++++++++++
>>>> Makefile | 1 +
>>>> atl1/Makefile | 30 ++++++++++++++++++++++++++++++
>>>> 3 files changed, 43 insertions(+)
>>>>
>>>> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
>>>> index 6e863aa..f503d10 100644
>>>> --- a/drivers/net/Kconfig
>>>> +++ b/drivers/net/Kconfig
>>>> @@ -2329,6 +2329,18 @@ config QLA3XXX
>>>> To compile this driver as a module, choose M here: the module
>>>> will be called qla3xxx.
>>>>
>>>> +config ATL1
>>>> + tristate "Attansic(R) L1 Gigabit Ethernet support (EXPERIMENTAL)"
>>>> + depends on NET_PCI && PCI && EXPERIMENTAL
>>>> + select CRC32
>>>> + select MII
>>>> + ---help---
>>>> + This driver supports Attansic L1 gigabit ethernet adapter.
>>>> +
>>>> + To compile this driver as a module, choose M here. The module
>>>> + will be called atl1.
>>>> +
>>>> +
>>>> endmenu
>>>
>>> One problem here is that MII depends on NET_ETHERNET, which is
>>> 10/100 ethernet, which may not be enabled if someone has only
>>> gigabit ethernet. :)
>>
>> I'm actually quite inclined to rip out all MII support entirely.
>> There's a lot of code in this driver that needs cleaning up
>> cosmetically, and removing deprecated features would certainly speed
>> things up. What do you think?
>
> All of that sounds like a good idea to me.
> I didn't realize that MII support is deprecated. Do you mean
> that it's deprecated for gigabit?
>
To be precise, mii-tool is deprecated, in favor of ethtool. There are
other things that use mii capabilities. Bonding uses miimon, but the
arp monitor is an alternative, and I don't think there's much overlap
between workloads where people care about bonding and workloads people
run on an Asus M2V motherboard, so I'm not sure there's much
justification to bother supporting the feature, except completeness.
Thus my question to netdev:
Would anyone care if we removed MII support from an experimental driver
for a chip that is only known to ship on non-OEM desktop boards?
-- Chris
Chris Snook <[email protected]> :
[...]
> To be precise, mii-tool is deprecated, in favor of ethtool. There are
$ man mii-tool
[...]
-v, --verbose
Display more detailed MII status information. If used twice,
^^^^^^^^^^^^^
also display raw MII register contents.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Is there a similar feature in ethtool ?
--
Ueimor