2006-11-20 16:29:32

by Vivek Goyal

[permalink] [raw]
Subject: [PATCH] x86_64: Align data segment to PAGE_SIZE boundary

Hi Andi,

This patch was previously part of relocatable kernel series but now I have
forked it out as it is required for 2.6.19 kernels and relocatable kernel
patches have to wait.

Please apply.

Thanks
Vivek


o Explicitly align data segment to PAGE_SIZE boundary otherwise depending on
config options and tool chain it might be placed on a non PAGE_SIZE aligned
boundary and vmlinux loaders like kexec fail when they encounter a
PT_LOAD type segment which is not aligned to PAGE_SIZE boundary.

Signed-off-by: Vivek Goyal <[email protected]>
---

arch/x86_64/kernel/vmlinux.lds.S | 1 +
1 file changed, 1 insertion(+)

diff -puN arch/x86_64/kernel/vmlinux.lds.S~x86_64-align-data-segment-to-4K-boundary arch/x86_64/kernel/vmlinux.lds.S
--- linux-2.6.19-rc6-reloc/arch/x86_64/kernel/vmlinux.lds.S~x86_64-align-data-segment-to-4K-boundary 2006-11-17 00:05:06.000000000 -0500
+++ linux-2.6.19-rc6-reloc-root/arch/x86_64/kernel/vmlinux.lds.S 2006-11-17 00:05:06.000000000 -0500
@@ -60,6 +60,7 @@ SECTIONS
}
#endif

+ . = ALIGN(PAGE_SIZE); /* Align data segment to page size boundary */
/* Data */
.data : AT(ADDR(.data) - LOAD_OFFSET) {
*(.data)
_


2006-11-21 09:38:45

by Andi Kleen

[permalink] [raw]
Subject: Re: [PATCH] x86_64: Align data segment to PAGE_SIZE boundary

On Mon, Nov 20, 2006 at 11:29:09AM -0500, Vivek Goyal wrote:
> Hi Andi,
>
> This patch was previously part of relocatable kernel series but now I have
> forked it out as it is required for 2.6.19 kernels and relocatable kernel
> patches have to wait.

I sent it to Linus. Thanks.

-Andi