PATCH: Implementation of acpi_video_get_level
(patch file attached)
acpi_video_get_next_level was supposed to implement an algorithm to
select a new brightness level based on the old brightness level of an
ACPI video device, but it simply says "/* Fix me */" and returns the
current brightness.
This patch implements acpi_video_get_next_level properly. It had to
change a few constants at the top of the file because they were
(apparently) wrong, but it appears to work on my Dell Inspiron e1405
(with BIOS A05 only--BIOS A04 doesn't seem to send ACPI video hotkey
events).
I'm sending this to Len Brown, the linux-kernel and linux-acpi lists at
kernel.org, the acpi-devel list at Sourceforge, and the linux-acpi alias
at Intel. I'm not sure who should be the one to apply it, but it's a
small and simple enough patch that it shouldn't require a complicated
review.
Thanks for your time, and hope this helps,
Thomas Tuttle
Whoops, just forgot something:
Signed-off-by: Thomas Tuttle <[email protected]>
--Thomas Tuttle
I've got a patch that fixes acpi_video_get_next_level in the ACPI video
driver. I sent it to linux-kernel, linux-acpi, and some people at
Intel. It's a very short and simple patch that fixes the brightness
hotkeys on my laptop, and probably others. (The function it fixes had
/* Fix me */ written in it.)
Where or how should I send this patch so that it can be included in the
mainline kernel?
Thanks,
Thomas Tuttle