2006-11-25 19:17:14

by Adrian Bunk

Subject: [2.6 patch] make hdlc_setup() static again

On Mon, Jun 26, 2006 at 09:28:14PM +0200, Krzysztof Halasa wrote:
> Adrian Bunk <[email protected]> writes:
>
> > hdlc_setup() is now EXPORTed as per David's request.
> >
> > Is a usage of this export pending for the near future
>
> I'm told it is.

It's still not used...

So let's unexport it again until some driver that actually uses it shows up.

> Krzysztof Halasa

cu
Adrian


<-- snip -->


hdlc_setup was exported, but this export was never used.

If adriver using it actually shows up it can still be exported again.

Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.19-rc6-mm1/drivers/net/wan/hdlc.c.old 2006-11-25 00:16:13.000000000 +0100
+++ linux-2.6.19-rc6-mm1/drivers/net/wan/hdlc.c 2006-11-25 00:16:26.000000000 +0100
@@ -222,7 +222,7 @@
return -EINVAL;
}

-void hdlc_setup(struct net_device *dev)
+static void hdlc_setup(struct net_device *dev)
{
hdlc_device *hdlc = dev_to_hdlc(dev);

@@ -325,7 +325,6 @@
EXPORT_SYMBOL(hdlc_open);
EXPORT_SYMBOL(hdlc_close);
EXPORT_SYMBOL(hdlc_ioctl);
-EXPORT_SYMBOL(hdlc_setup);
EXPORT_SYMBOL(alloc_hdlcdev);
EXPORT_SYMBOL(unregister_hdlc_device);
EXPORT_SYMBOL(register_hdlc_protocol);

2006-11-26 19:22:58

by Krzysztof Halasa

Subject: Re: [2.6 patch] make hdlc_setup() static again

Adrian Bunk <[email protected]> writes:

> It's still not used...
>
> So let's unexport it again until some driver that actually uses it shows up.

Fair enough.
--
Krzysztof Halasa