2006-11-10 14:49:10

by Samuel Thibault

[permalink] [raw]
Subject: Tulip dmfe carrier detection

Hi,

The dmfe module lacks netif stuff for carrier detection, while the board
does report carrier status. Here is a patch.

Note: there are probably a lot more ethtool stuff that could be added,
but carrier sense is really a must.

Samuel


Attachments:
(No filename) (239.00 B)
patch (1.58 kB)
Download all attachments

2006-11-25 22:21:22

by Samuel Thibault

[permalink] [raw]
Subject: Re: Tulip dmfe carrier detection

Hi,

Samuel Thibault, le Fri 10 Nov 2006 15:49:19 +0100, a ?crit :
> The dmfe module lacks netif stuff for carrier detection, while the board
> does report carrier status. Here is a patch.

Just an additional fixup: the default state should be carrier off.
This fixes boot carrier detection.

Samuel

--- drivers/net/tulip/dmfe-orig.c 2006-10-01 16:09:49.000000000 +0200
+++ drivers/net/tulip/dmfe.c 2006-11-25 21:23:52.000000000 +0100
@@ -426,6 +426,7 @@
dev->poll_controller = &poll_dmfe;
#endif
dev->ethtool_ops = &netdev_ethtool_ops;
+ netif_carrier_off(db->dev);
spin_lock_init(&db->lock);

pci_read_config_dword(pdev, 0x50, &pci_pmr);