2006-11-29 17:05:54

by Jordan Crouse

[permalink] [raw]
Subject: [PATCH] Trivial cleanup in the PCI IDs for the CS5535

GEODE: Update and fixup the PCI IDs for the CS5535

From: Jordan Crouse <[email protected]>

Clean up redundant and poorly worded PCI IDs

Signed-off-by: Jordan Crouse <[email protected]>
---

drivers/video/geode/gxfb_core.c | 2 +-
include/linux/pci_ids.h | 5 ++---
2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/video/geode/gxfb_core.c b/drivers/video/geode/gxfb_core.c
index 83ab18a..7b8d7d9 100644
--- a/drivers/video/geode/gxfb_core.c
+++ b/drivers/video/geode/gxfb_core.c
@@ -397,7 +397,7 @@ static void gxfb_remove(struct pci_dev *
}

static struct pci_device_id gxfb_id_table[] = {
- { PCI_VENDOR_ID_NS, PCI_DEVICE_ID_NS_CS5535_VIDEO,
+ { PCI_VENDOR_ID_NS, PCI_DEVICE_ID_NS_GX_VIDEO,
PCI_ANY_ID, PCI_ANY_ID, PCI_BASE_CLASS_DISPLAY << 16,
0xff0000, 0 },
{ 0, }
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index fa4e1d7..9adbfbf 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -390,7 +390,7 @@ #define PCI_DEVICE_ID_NS_CS5535_ISA 0x00
#define PCI_DEVICE_ID_NS_CS5535_IDE 0x002d
#define PCI_DEVICE_ID_NS_CS5535_AUDIO 0x002e
#define PCI_DEVICE_ID_NS_CS5535_USB 0x002f
-#define PCI_DEVICE_ID_NS_CS5535_VIDEO 0x0030
+#define PCI_DEVICE_ID_NS_GX_VIDEO 0x0030
#define PCI_DEVICE_ID_NS_SATURN 0x0035
#define PCI_DEVICE_ID_NS_SCx200_BRIDGE 0x0500
#define PCI_DEVICE_ID_NS_SCx200_SMI 0x0501
@@ -403,8 +403,7 @@ #define PCI_DEVICE_ID_NS_SC1100_SMI 0x05
#define PCI_DEVICE_ID_NS_SC1100_XBUS 0x0515
#define PCI_DEVICE_ID_NS_87410 0xd001

-#define PCI_DEVICE_ID_NS_CS5535_HOST_BRIDGE 0x0028
-#define PCI_DEVICE_ID_NS_CS5535_ISA_BRIDGE 0x002b
+#define PCI_DEVICE_ID_NS_GX_HOST_BRIDGE 0x0028

#define PCI_VENDOR_ID_TSENG 0x100c
#define PCI_DEVICE_ID_TSENG_W32P_2 0x3202


Attachments:
(No filename) (345.00 B)
geode-trivial.patch (1.74 kB)
Download all attachments

2006-11-29 17:29:06

by Alan

[permalink] [raw]
Subject: Re: [PATCH] Trivial cleanup in the PCI IDs for the CS5535

On Wed, 29 Nov 2006 10:05:16 -0700
"Jordan Crouse" <[email protected]> wrote:

> Attached is a trivial patch that renames a poorly worded PCI ID
> for the Geode GX and CS5535 companion chips. The graphics processor
> and host bridge actually live in the northbridge on the integrated
> processor, not in the companion chip.

Acked-by: Alan Cox <[email protected]>