2006-11-25 19:15:45

by Adrian Bunk

Subject: [2.6 patch] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static

This patch makes the needlessly global mtdpart_setup() static.

Signed-off-by: Adrian Bunk <[email protected]>

---

This patch was already sent on:
- 27 Jun 2006

--- linux-2.6.17-mm2-full/drivers/mtd/cmdlinepart.c.old 2006-06-26 23:18:39.000000000 +0200
+++ linux-2.6.17-mm2-full/drivers/mtd/cmdlinepart.c 2006-06-26 23:18:51.000000000 +0200
@@ -346,7 +346,7 @@
*
* This function needs to be visible for bootloaders.
*/
-int mtdpart_setup(char *s)
+static int mtdpart_setup(char *s)
{
cmdline = s;
return 1;

2006-11-28 22:19:53

by David Woodhouse

Subject: Re: [2.6 patch] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static

On Sat, 2006-11-25 at 20:15 +0100, Adrian Bunk wrote:
> This patch makes the needlessly global mtdpart_setup() static.
>
> Signed-off-by: Adrian Bunk <[email protected]>

Applied; thanks.

--
dwmw2

2006-11-30 18:45:58

by Andy Isaacson

Subject: Re: [2.6 patch] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static

On Sat, Nov 25, 2006 at 08:15:41PM +0100, Adrian Bunk wrote:
> This patch makes the needlessly global mtdpart_setup() static.
>
> @@ -346,7 +346,7 @@
> *
> * This function needs to be visible for bootloaders.
> */
> -int mtdpart_setup(char *s)
> +static int mtdpart_setup(char *s)
> {
> cmdline = s;
> return 1;

Jarkko,

You're recorded as submitting the original patch to make this
non-static:
http://linux.bkbits.net:8080/linux-2.6/diffs/drivers/mtd/[email protected]?nav=index.html|src/|src/drivers|src/drivers/mtd|hist/drivers/mtd/cmdlinepart.c

Is this change correct?

If so, it should also delete the "needs to be visible" comment.

-andy

2006-12-01 13:50:47

by Jarkko Lavinen

Subject: Re: [2.6 patch] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static

Our bootloader once used mtdpart_setup() for passing mtd partitions to
kernel. We do not do that any more and instead use the kernel command line
for passing the information.

Jarkko Lavinen

On Thu, Nov 30, 2006 at 10:45:56AM -0800, ext Andy Isaacson wrote:
> On Sat, Nov 25, 2006 at 08:15:41PM +0100, Adrian Bunk wrote:
> > This patch makes the needlessly global mtdpart_setup() static.
> >
> > @@ -346,7 +346,7 @@
> > *
> > * This function needs to be visible for bootloaders.
> > */
> > -int mtdpart_setup(char *s)
> > +static int mtdpart_setup(char *s)
> > {
> > cmdline = s;
> > return 1;
>
> Jarkko,
>
> You're recorded as submitting the original patch to make this
> non-static:
> http://linux.bkbits.net:8080/linux-2.6/diffs/drivers/mtd/[email protected]?nav=index.html|src/|src/drivers|src/drivers/mtd|hist/drivers/mtd/cmdlinepart.c
>
> Is this change correct?
>
> If so, it should also delete the "needs to be visible" comment.
>
> -andy