This patch removes the usage of GCC_VERSION from arch/parisc/Makefile.
There are no functional changes, it simply makes it a bit shorter (and
removes the last instance of GCC_VERSION in the kernel).
Signed-off-by: Adrian Bunk <[email protected]>
Acked-by: Kyle McMartin <[email protected]>
---
This patch was already sent on:
- 21 Nov 2006
- 19 Aug 2006
- 12 Jan 2006
--- linux-2.6.15-mm3-hppa/arch/parisc/Makefile.old 2006-01-12 03:11:45.000000000 +0100
+++ linux-2.6.15-mm3-hppa/arch/parisc/Makefile 2006-01-12 03:12:35.000000000 +0100
@@ -35,12 +35,8 @@
OBJCOPY_FLAGS =-O binary -R .note -R .comment -S
-GCC_VERSION := $(call cc-version)
-ifneq ($(shell if [ -z $(GCC_VERSION) ] ; then echo "bad"; fi ;),)
-$(error Sorry, couldn't find ($(cc-version)).)
-endif
-ifneq ($(shell if [ $(GCC_VERSION) -lt 0303 ] ; then echo "bad"; fi ;),)
-$(error Sorry, your compiler is too old ($(GCC_VERSION)). GCC v3.3 or above is required.)
+ifneq ($(shell if [ $(call cc-version) -lt 0303 ] ; then echo "bad"; fi ;),)
+$(error Sorry, your compiler is too old. GCC v3.3 or above is required.)
endif
cflags-y := -pipe
On Fri, Dec 01, 2006 at 12:49:08PM +0100, Adrian Bunk wrote:
> This patch removes the usage of GCC_VERSION from arch/parisc/Makefile.
>
> There are no functional changes, it simply makes it a bit shorter (and
> removes the last instance of GCC_VERSION in the kernel).
Thanks!
I've committed a variant of this to git://git.parisc-linux.org/git/linux-2.6.git
I didn't test the failure case - only that it doesn't trigger with
my current gcc 4.x compilers.
I expect Kyle will push parisc tree to linus in the near future.
Signed-off-by: Grant Grundler <[email protected]>
diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
index 9b7e424..760567a 100644
--- a/arch/parisc/Makefile
+++ b/arch/parisc/Makefile
@@ -35,12 +35,8 @@ FINAL_LD=$(CROSS_COMPILE)ld --warn-commo
OBJCOPY_FLAGS =-O binary -R .note -R .comment -S
-GCC_VERSION := $(call cc-version)
-ifneq ($(shell if [ -z $(GCC_VERSION) ] ; then echo "bad"; fi ;),)
-$(error Sorry, couldn't find ($(cc-version)).)
-endif
-ifneq ($(shell if [ $(GCC_VERSION) -lt 0303 ] ; then echo "bad"; fi ;),)
-$(error Sorry, your compiler is too old ($(GCC_VERSION)). GCC v3.3 or above is required.)
+ifneq ($(call cc-ifversion, -lt, 0303, "bad"),)
+$(error Sorry, GCC v3.3 or above is required.)
endif
cflags-y := -pipe
On Fri, Dec 01, 2006 at 11:23:55AM -0700, Grant Grundler wrote:
> I've committed a variant of this to git://git.parisc-linux.org/git/linux-2.6.git
> I didn't test the failure case - only that it doesn't trigger with
> my current gcc 4.x compilers.
>
> I expect Kyle will push parisc tree to linus in the near future.
>
> Signed-off-by: Grant Grundler <[email protected]>
>
I like the version ggg committed to our cvs better (and I verified it
correctly functions with gcc-3.0 from Debian woody.)
Picked into my tree.
Cheers,
Kyle