This is the start of the stable review cycle for the 2.6.19.1 release.
There are 32 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let us know. If anyone is a maintainer of the proper subsystem, and
wants to add a Signed-off-by: line to the patch, please respond with it.
These patches are sent out with a number of different people on the
Cc: line. If you wish to be a reviewer, please email [email protected]
to add your name to the list. If you want to be off the reviewer list,
also email us.
Responses should be made by Mon Dec 11 00:00 UTC Anything received after
that time might be too late.
thanks,
the -stable release team
--
And a roll-up is available at:
http://www.kernel.org/pub/linux/kernel/people/chrisw/stable/patch-2.6.19.1-rc1.{gz,bz2}
-stable review patch. If anyone has any objections, please let us know.
------------------
From: David Miller <[email protected]>
NETLINK: Put {IFA,IFLA}_{RTA,PAYLOAD} macros back for userspace.
GLIBC uses them etc.
They are guarded by ifndef __KERNEL__ so nobody will start
accidently using them in the kernel again, it's just for
userspace.
Signed-off-by: David S. Miller <[email protected]>
Signed-off-by: Chris Wright <[email protected]>
---
commit c0279128f20aa3580b0b43aaa49f351f6bad5f30
Author: David S. Miller <[email protected]>
Date: Fri Dec 8 17:05:13 2006 -0800
include/linux/if_addr.h | 6 ++++++
include/linux/if_link.h | 6 ++++++
2 files changed, 12 insertions(+)
--- linux-2.6.19.orig/include/linux/if_addr.h
+++ linux-2.6.19/include/linux/if_addr.h
@@ -52,4 +52,10 @@ struct ifa_cacheinfo
__u32 tstamp; /* updated timestamp, hundredths of seconds */
};
+/* backwards compatibility for userspace */
+#ifndef __KERNEL__
+#define IFA_RTA(r) ((struct rtattr*)(((char*)(r)) + NLMSG_ALIGN(sizeof(struct ifaddrmsg))))
+#define IFA_PAYLOAD(n) NLMSG_PAYLOAD(n,sizeof(struct ifaddrmsg))
+#endif
+
#endif
--- linux-2.6.19.orig/include/linux/if_link.h
+++ linux-2.6.19/include/linux/if_link.h
@@ -82,6 +82,12 @@ enum
#define IFLA_MAX (__IFLA_MAX - 1)
+/* backwards compatibility for userspace */
+#ifndef __KERNEL__
+#define IFLA_RTA(r) ((struct rtattr*)(((char*)(r)) + NLMSG_ALIGN(sizeof(struct ifinfomsg))))
+#define IFLA_PAYLOAD(n) NLMSG_PAYLOAD(n,sizeof(struct ifinfomsg))
+#endif
+
/* ifi_flags.
IFF_* flags.
Hi
On Saturday 09 December 2006 00:57, you wrote:
> This is the start of the stable review cycle for the 2.6.19.1 release.
> There are 32 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let us know. If anyone is a maintainer of the proper subsystem, and
> wants to add a Signed-off-by: line to the patch, please respond with it.
At least
http://kernel.org/pub/linux/kernel/people/chrisw/stable/patch-2.6.19.1-rc1.gz
and
http://kernel.org/pub/linux/kernel/people/chrisw/stable/patch-2.6.19.1-rc2.gz
seem to contain an incompletely applied "[patch 24/32] add bottom_half.h",
bottom_half.h itself is missing, while interrupt.h and spinlock.h are changed
to use the missing file:
$ wget -qO- http://kernel.org/pub/linux/kernel/people/chrisw/stable/patch-2.6.19.1-rc2.gz | gzip -dc | grep bottom_half
+#include <linux/bottom_half.h>
+#include <linux/bottom_half.h>
$ wget -qO- http://kernel.org/pub/linux/kernel/people/chrisw/stable/patch-2.6.19.1-rc1.gz | gzip -dc | grep bottom_half
+#include <linux/bottom_half.h>
+#include <linux/bottom_half.h>
> These patches are sent out with a number of different people on the
> Cc: line. If you wish to be a reviewer, please email [email protected]
> to add your name to the list. If you want to be off the reviewer list,
> also email us.
>
> Responses should be made by Mon Dec 11 00:00 UTC Anything received after
> that time might be too late.
>
> thanks,
>
> the -stable release team
Thanks a lot for the -stable rc patches
Stefan Lippers-Hollmann
* Stefan Lippers-Hollmann ([email protected]) wrote:
> At least
> http://kernel.org/pub/linux/kernel/people/chrisw/stable/patch-2.6.19.1-rc1.gz
> and
> http://kernel.org/pub/linux/kernel/people/chrisw/stable/patch-2.6.19.1-rc2.gz
> seem to contain an incompletely applied "[patch 24/32] add bottom_half.h",
> bottom_half.h itself is missing, while interrupt.h and spinlock.h are changed
> to use the missing file:
>
> $ wget -qO- http://kernel.org/pub/linux/kernel/people/chrisw/stable/patch-2.6.19.1-rc2.gz | gzip -dc | grep bottom_half
> +#include <linux/bottom_half.h>
> +#include <linux/bottom_half.h>
> $ wget -qO- http://kernel.org/pub/linux/kernel/people/chrisw/stable/patch-2.6.19.1-rc1.gz | gzip -dc | grep bottom_half
> +#include <linux/bottom_half.h>
> +#include <linux/bottom_half.h>
Sorry about that, I regenerated and made sure I picked up new files.
I've pushed up an rc3 (mirroring is a bit slow).
thanks,
-chris