2006-12-08 23:58:44

by Chris Wright

[permalink] [raw]
Subject: [patch 08/32] cryptoloop: Select CRYPTO_CBC

-stable review patch. If anyone has any objections, please let us know.
------------------

From: Herbert Xu <[email protected]>

As CBC is the default chaining method for cryptoloop, we should select
it from cryptoloop to ease the transition.

Signed-off-by: Herbert Xu <[email protected]>
Signed-off-by: Chris Wright <[email protected]>
---
drivers/block/Kconfig | 1 +
1 file changed, 1 insertion(+)

--- linux-2.6.19.orig/drivers/block/Kconfig
+++ linux-2.6.19/drivers/block/Kconfig
@@ -305,6 +305,7 @@ config BLK_DEV_LOOP
config BLK_DEV_CRYPTOLOOP
tristate "Cryptoloop Support"
select CRYPTO
+ select CRYPTO_CBC
depends on BLK_DEV_LOOP
---help---
Say Y here if you want to be able to use the ciphers that are

--


2006-12-09 06:33:08

by Rene Herman

[permalink] [raw]
Subject: Re: [patch 08/32] cryptoloop: Select CRYPTO_CBC

Chris Wright wrote:

> -stable review patch. If anyone has any objections, please let us know.
> ------------------
>
> From: Herbert Xu <[email protected]>
>
> As CBC is the default chaining method for cryptoloop, we should select
> it from cryptoloop to ease the transition.
>
> Signed-off-by: Herbert Xu <[email protected]>
> Signed-off-by: Chris Wright <[email protected]>
> ---
> drivers/block/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-2.6.19.orig/drivers/block/Kconfig
> +++ linux-2.6.19/drivers/block/Kconfig
> @@ -305,6 +305,7 @@ config BLK_DEV_LOOP
> config BLK_DEV_CRYPTOLOOP
> tristate "Cryptoloop Support"
> select CRYPTO
> + select CRYPTO_CBC
> depends on BLK_DEV_LOOP
> ---help---
> Say Y here if you want to be able to use the ciphers that are
>

dm-crypt needs CBC in the same manner -- normal (via howto) use of
cryptsetup doesn't work otherwise, same as with cryptoloop.

Rene.

2006-12-09 22:50:48

by Herbert Xu

[permalink] [raw]
Subject: Re: [patch 08/32] cryptoloop: Select CRYPTO_CBC

On Sat, Dec 09, 2006 at 07:32:02AM +0100, Rene Herman wrote:
>
> dm-crypt needs CBC in the same manner -- normal (via howto) use of
> cryptsetup doesn't work otherwise, same as with cryptoloop.

Good point. Here's the patch for 2.6.19 and 2.6.20.

[CRYPTO] dm-crypt: Select CRYPTO_CBC

As CBC is the default chaining method for cryptoloop, we should select
it from cryptoloop to ease the transition. Spotted by Rene Herman.

Signed-off-by: Herbert Xu <[email protected]>

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
7cd650c7e042e3c201fb3c401780c909d44b0e5d
diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
index c92c152..4540ade 100644
--- a/drivers/md/Kconfig
+++ b/drivers/md/Kconfig
@@ -215,6 +215,7 @@ config DM_CRYPT
tristate "Crypt target support"
depends on BLK_DEV_DM && EXPERIMENTAL
select CRYPTO
+ select CRYPTO_CBC
---help---
This device-mapper target allows you to create a device that
transparently encrypts the data on it. You'll need to activate