this is against 2.6.19-git17
hope this correct
raz
On 12/11/06, Jens Axboe <[email protected]> wrote:
> On Mon, Dec 11 2006, Raz Ben-Jehuda(caro) wrote:
> > On 12/11/06, Jens Axboe <[email protected]> wrote:
> > >On Sun, Dec 10 2006, [email protected] wrote:
> > >> From: "Raz Ben-Jehuda(caro)" <[email protected]>
> > >>
> > >> This will encourage read request to be on only one device, so we will
> > >often be
> > >> able to bypass the cache for read requests.
> > >>
> > >> Signed-off-by: Neil Brown <[email protected]>
> > >> Cc: Jens Axboe <[email protected]>
> > >> Signed-off-by: Andrew Morton <[email protected]>
> > >> ---
> > >>
> > >> drivers/md/raid5.c | 24 ++++++++++++++++++++++++
> > >> 1 file changed, 24 insertions(+)
> > >>
> > >> diff -puN drivers/md/raid5.c~md-define-raid5_mergeable_bvec
> > >drivers/md/raid5.c
> > >> --- a/drivers/md/raid5.c~md-define-raid5_mergeable_bvec
> > >> +++ a/drivers/md/raid5.c
> > >> @@ -2611,6 +2611,28 @@ static int raid5_congested(void *data, i
> > >> return 0;
> > >> }
> > >>
> > >> +/* We want read requests to align with chunks where possible,
> > >> + * but write requests don't need to.
> > >> + */
> > >> +static int raid5_mergeable_bvec(request_queue_t *q, struct bio *bio,
> > >struct bio_vec *biovec)
> > >> +{
> > >> + mddev_t *mddev = q->queuedata;
> > >> + sector_t sector = bio->bi_sector + get_start_sect(bio->bi_bdev);
> > >> + int max;
> > >> + unsigned int chunk_sectors = mddev->chunk_size >> 9;
> > >> + unsigned int bio_sectors = bio->bi_size >> 9;
> > >> +
> > >> + if (bio_data_dir(bio))
> > >> + return biovec->bv_len; /* always allow writes to be
> > >mergeable */
> > >
> > >Please don't ever do that - you are making assumptions on the value of
> > >READ and WRITE.
> > >
> > > if (bio_data_dir(bio) == WRITE)
> > > ...
> > >
> > >If this has already been merged, please submit a patch correcting it.
> > >People end up copying code like this :-)
> > >
> > >--
> > >Jens Axboe
> > >
> > >
> >
> > thanks Jens
> > the attached is a fix.
>
> But the patch is already merged, so the patch needs to be against Linus'
> current tree.
>
> --
> Jens Axboe
>
>
--
Raz
On Mon, Dec 11 2006, Raz Ben-Jehuda(caro) wrote:
> this is against 2.6.19-git17
> hope this correct
Patch itself looks fine. Some general suggestions for the future:
- Don't top post on lkml
- Inline patches, and always include a description and a Signed-off-by
line.
- Documentation/SubmittingPatches has a lot of good info.
--
Jens Axboe