2006-12-13 02:17:42

by Pete Zaitcev

[permalink] [raw]
Subject: Weird code in scripts/kconfig/Makefile

Hi, Roman & All:

In 2.6.19 (and Linus' curent tree), I found the following:

libpath=$$dir/lib; lib=qt; osdir=""; \
$(HOSTCXX) -print-multi-os-directory > /dev/null 2>&1 && \
osdir=x$$($(HOSTCXX) -print-multi-os-directory); \
test -d $$libpath/$$osdir && libpath=$$libpath/$$osdir; \

What does the little 'x' do in front of $$(foo)? It looks suspiciously
like a typo to me.

I think Jason caught it, but I didn't see a correction sent out.

-- Pete


2006-12-13 02:48:58

by Jason Baron

[permalink] [raw]
Subject: Re: Weird code in scripts/kconfig/Makefile


On Tue, 12 Dec 2006, Pete Zaitcev wrote:

> Hi, Roman & All:
>
> In 2.6.19 (and Linus' curent tree), I found the following:
>
> libpath=$$dir/lib; lib=qt; osdir=""; \
> $(HOSTCXX) -print-multi-os-directory > /dev/null 2>&1 && \
> osdir=x$$($(HOSTCXX) -print-multi-os-directory); \
> test -d $$libpath/$$osdir && libpath=$$libpath/$$osdir; \
>
> What does the little 'x' do in front of $$(foo)? It looks suspiciously
> like a typo to me.
>
> I think Jason caught it, but I didn't see a correction sent out.
>

yes. looks like an error to me too...i left it out of an internal patch to
this code. Since we are testing for the existence of the directory, it has
probably gone unnoticed.

2006-12-13 12:08:05

by Roman Zippel

[permalink] [raw]
Subject: Re: Weird code in scripts/kconfig/Makefile

Hi,

On Tue, 12 Dec 2006, Pete Zaitcev wrote:

> In 2.6.19 (and Linus' curent tree), I found the following:
>
> libpath=$$dir/lib; lib=qt; osdir=""; \
> $(HOSTCXX) -print-multi-os-directory > /dev/null 2>&1 && \
> osdir=x$$($(HOSTCXX) -print-multi-os-directory); \
> test -d $$libpath/$$osdir && libpath=$$libpath/$$osdir; \
>
> What does the little 'x' do in front of $$(foo)? It looks suspiciously
> like a typo to me.

Indeed, it looks like it. It's the fallback path nowadays, so I guess it
wasn't noticed so far.

bye, Roman