Signed-off-by: Dave Jones <[email protected]>
--- linux-2.6.19.noarch/drivers/media/video/Kconfig~ 2006-12-12 09:51:16.000000000 -0500
+++ linux-2.6.19.noarch/drivers/media/video/Kconfig 2006-12-12 09:51:32.000000000 -0500
@@ -668,7 +668,7 @@ config VIDEO_M32R_AR_M64278
config VIDEO_CAFE_CCIC
tristate "Marvell 88ALP01 (Cafe) CMOS Camera Controller support"
- depends on I2C && VIDEO_V4L2
+ depends on I2C && VIDEO_V4L2 && X86_32
select VIDEO_OV7670
---help---
This is a video4linux2 driver for the Marvell 88ALP01 integrated
--
http://www.codemonkey.org.uk
Dave Jones <[email protected]> wrote:
> - depends on I2C && VIDEO_V4L2
> + depends on I2C && VIDEO_V4L2 && X86_32
Any particular reason why? I wouldn't be surprised to see Cafe used
with other processors in the future. And I happen to know the driver
works on x86-64 systems...or at least it did a few iterations back.
In any case, x86 for now is fine, I guess; we can always change it later
if need be.
jon
On Tue, Dec 12, 2006 at 08:12:52AM -0700, Jonathan Corbet wrote:
> Dave Jones <[email protected]> wrote:
>
> > - depends on I2C && VIDEO_V4L2
> > + depends on I2C && VIDEO_V4L2 && X86_32
>
> Any particular reason why?
Just seemed odd to be offered the option when I was building
an ia64 kernel given its extremely unlikely to ever appear there.
[gads, an ia64 olpc, what a thought...]
Dave
--
http://www.codemonkey.org.uk
On Tue, 12 Dec 2006 10:39:56 -0500
Dave Jones <[email protected]> wrote:
> On Tue, Dec 12, 2006 at 08:12:52AM -0700, Jonathan Corbet wrote:
> > Dave Jones <[email protected]> wrote:
> >
> > > - depends on I2C && VIDEO_V4L2
> > > + depends on I2C && VIDEO_V4L2 && X86_32
> >
> > Any particular reason why?
>
> Just seemed odd to be offered the option when I was building
> an ia64 kernel given its extremely unlikely to ever appear there.
It means we catch portability bugs early and people changing core code
catch problems even if their platform is not X86_32. The practice for
almost all out drivers is thus not to put in arch dependancies unless
they genuinely do not build on arbitary platforms.
NAK
On Tue, Dec 12, 2006 at 05:40:55PM +0000, Alan Cox wrote:
> > > > - depends on I2C && VIDEO_V4L2
> > > > + depends on I2C && VIDEO_V4L2 && X86_32
> > >
> > > Any particular reason why?
> >
> > Just seemed odd to be offered the option when I was building
> > an ia64 kernel given its extremely unlikely to ever appear there.
>
> It means we catch portability bugs early and people changing core code
> catch problems even if their platform is not X86_32. The practice for
> almost all out drivers is thus not to put in arch dependancies unless
> they genuinely do not build on arbitary platforms.
>
> NAK
Given this could in theory turn up in USB form one day, and some
lunatic may actually plug one into an ia64, I see your point.
Unlikely, but feasible.
Dave
--
http://www.codemonkey.org.uk
In-Reply-To: <[email protected]>
On Tue, 12 Dec 2006 10:39:56 -0500, Dave Jones wrote:
> [gads, an ia64 olpc, what a thought...]
Teacher in front of a classroom full of students, all madly
pedaling away on stationary bicycles: "Okay, class, just another
hour of this and we can use the computers for a few minutes."
--
MBTI: IXTP