2006-12-14 17:34:49

by Alistair John Strachan

[permalink] [raw]
Subject: libata-pata with ICH4, rootfs

Hi Alan,

Is it possible to use pata_mpiix (or pata_oldpiix) with an ICH4 IDE controller
and boot off it?

I've tried compiling both drivers into the kernel, and totally disabling
CONFIG_IDE, but it doesn't boot. dmesg doesn't indicate any detection has
taken place. The old IDE layer works fine.

--
Cheers,
Alistair.

Final year Computer Science undergraduate.
1F2 55 South Clerk Street, Edinburgh, UK.


2006-12-14 18:12:00

by Alan

[permalink] [raw]
Subject: Re: libata-pata with ICH4, rootfs

On Thu, 14 Dec 2006 17:14:55 +0000
Alistair John Strachan <[email protected]> wrote:

> Hi Alan,
>
> Is it possible to use pata_mpiix (or pata_oldpiix) with an ICH4 IDE controller
> and boot off it?

ata_piix (the SATA/PATA driver) deals with the ICH4. pata_mpiix is
specifically for the Intel MPIIX laptop chipset and pata_oldpiix
explicitly for the original PIIX chipset and none of the later ones.

2006-12-14 18:32:37

by Alistair John Strachan

[permalink] [raw]
Subject: Re: libata-pata with ICH4, rootfs

On Thursday 14 December 2006 18:20, Alan wrote:
> On Thu, 14 Dec 2006 17:14:55 +0000
>
> Alistair John Strachan <[email protected]> wrote:
> > Hi Alan,
> >
> > Is it possible to use pata_mpiix (or pata_oldpiix) with an ICH4 IDE
> > controller and boot off it?
>
> ata_piix (the SATA/PATA driver) deals with the ICH4. pata_mpiix is
> specifically for the Intel MPIIX laptop chipset and pata_oldpiix
> explicitly for the original PIIX chipset and none of the later ones.

Correct me if I'm wrong, but SATA wasn't available on ICH4. Only 5 and
greater. The kernel help text agrees with me.

My IDE controller usually works with CONFIG_BLK_DEV_PIIX; I was interested in
using your pata_xxx drivers in replacement, assuming there was support.

--
Cheers,
Alistair.

Final year Computer Science undergraduate.
1F2 55 South Clerk Street, Edinburgh, UK.

2006-12-14 19:54:35

by Bill Nottingham

[permalink] [raw]
Subject: Re: libata-pata with ICH4, rootfs

Alistair John Strachan ([email protected]) said:
> > > Is it possible to use pata_mpiix (or pata_oldpiix) with an ICH4 IDE
> > > controller and boot off it?
> >
> > ata_piix (the SATA/PATA driver) deals with the ICH4. pata_mpiix is
> > specifically for the Intel MPIIX laptop chipset and pata_oldpiix
> > explicitly for the original PIIX chipset and none of the later ones.
>
> Correct me if I'm wrong, but SATA wasn't available on ICH4. Only 5 and
> greater. The kernel help text agrees with me.
>
> My IDE controller usually works with CONFIG_BLK_DEV_PIIX; I was interested in
> using your pata_xxx drivers in replacement, assuming there was support.

pata_xxx is for older PIIX, not ICH4. ICH* is handled by ata_piix, which
can drive both SATA *and* PATA in the new kernels. In fact:

[notting@nostromo: ~]$ lspci | grep IDE
00:1f.1 IDE interface: Intel Corporation 82801DBM (ICH4-M) IDE Controller (rev 01)
[notting@nostromo: ~]$ dmesg | grep ata
...
ata_piix 0000:00:1f.1: version 2.00ac6
ata1: PATA max UDMA/100 cmd 0x1F0 ctl 0x3F6 bmdma 0x1860 irq 14
ata2: PATA max UDMA/100 cmd 0x170 ctl 0x376 bmdma 0x1868 irq 15
...
[notting@nostromo: ~]$ uname -r
2.6.19-1.2839.fc7

Bill

2006-12-14 20:06:37

by Alistair John Strachan

[permalink] [raw]
Subject: [PATCH] Fix help text for CONFIG_ATA_PIIX

On Thursday 14 December 2006 19:53, Bill Nottingham wrote:
> Alistair John Strachan ([email protected]) said:
> > > > Is it possible to use pata_mpiix (or pata_oldpiix) with an ICH4 IDE
> > > > controller and boot off it?
> > >
> > > ata_piix (the SATA/PATA driver) deals with the ICH4. pata_mpiix is
> > > specifically for the Intel MPIIX laptop chipset and pata_oldpiix
> > > explicitly for the original PIIX chipset and none of the later ones.
> >
> > Correct me if I'm wrong, but SATA wasn't available on ICH4. Only 5 and
> > greater. The kernel help text agrees with me.
> >
> > My IDE controller usually works with CONFIG_BLK_DEV_PIIX; I was
> > interested in using your pata_xxx drivers in replacement, assuming there
> > was support.
>
> pata_xxx is for older PIIX, not ICH4. ICH* is handled by ata_piix, which
> can drive both SATA *and* PATA in the new kernels.

Thanks for clarifying Bill, and sorry Alan. ata_piix does indeed work
correctly. The help text is a bit confusing:

config ATA_PIIX
tristate "Intel PIIX/ICH SATA support"
depends on PCI
help
This option enables support for ICH5/6/7/8 Serial ATA.
If PATA support was enabled previously, this enables
support for select Intel PIIX/ICH PATA host controllers.

"Enabled previously"?

--
Cheers,
Alistair.

Final year Computer Science undergraduate.
1F2 55 South Clerk Street, Edinburgh, UK.

2006-12-15 00:36:17

by Alan

[permalink] [raw]
Subject: Re: libata-pata with ICH4, rootfs

On Thu, 14 Dec 2006 18:32:50 +0000
Alistair John Strachan <[email protected]> wrote:
> Correct me if I'm wrong, but SATA wasn't available on ICH4. Only 5 and
> greater. The kernel help text agrees with me.
>
> My IDE controller usually works with CONFIG_BLK_DEV_PIIX; I was interested in
> using your pata_xxx drivers in replacement, assuming there was support.

The ata_piix driver does both SATA and PATA for the later chips. The
reason for this is that the SATA ICH devices have PATA ports as well
which are closely interlinked in how they operate. Since the ata_piix
driver has to drive those and the PATA only ones from PIIX3 onward are
similar it handles them all.

Alan

2006-12-15 00:51:11

by Alan

[permalink] [raw]
Subject: Re: [PATCH] Fix help text for CONFIG_ATA_PIIX

> Thanks for clarifying Bill, and sorry Alan. ata_piix does indeed work
> correctly. The help text is a bit confusing:

The help text is out of date - thanks that is a real bug

2006-12-16 12:46:21

by Alan

[permalink] [raw]
Subject: [PATCH] Fix help text for CONFIG_ATA_PIIX

> Thanks for clarifying Bill, and sorry Alan. ata_piix does indeed work
> correctly. The help text is a bit confusing:
>
> config ATA_PIIX
> tristate "Intel PIIX/ICH SATA support"
> depends on PCI
> help
> This option enables support for ICH5/6/7/8 Serial ATA.
> If PATA support was enabled previously, this enables
> support for select Intel PIIX/ICH PATA host controllers.

New help text

Signed-off-by: Alan Cox <[email protected]>

--- linux.vanilla-2.6.20-rc1/drivers/ata/Kconfig 2006-12-14 17:23:30.000000000 +0000
+++ linux-2.6.20-rc1/drivers/ata/Kconfig 2006-12-16 12:29:50.198153800 +0000
@@ -40,9 +40,9 @@
tristate "Intel PIIX/ICH SATA support"
depends on PCI
help
- This option enables support for ICH5/6/7/8 Serial ATA.
- If PATA support was enabled previously, this enables
- support for select Intel PIIX/ICH PATA host controllers.
+ This option enables support for ICH5/6/7/8 Serial ATA
+ and support for PATA on the Intel PIIX3/PIIX4/ICH series
+ PATA host controllers.

If unsure, say N.

2006-12-16 16:08:14

by Jeff Garzik

[permalink] [raw]
Subject: Re: [PATCH] Fix help text for CONFIG_ATA_PIIX

applied to #upstream-fixes