2006-12-15 01:34:07

by Chris Wright

[permalink] [raw]
Subject: [patch 12/24] dm snapshot: fix freeing pending exception

2.6.18-stable review patch. If anyone has any objections, please let us know.
------------------

From: Milan Broz <[email protected]>

Fix oops when removing full snapshot
kernel bugzilla bug 7040

If a snapshot became invalid (full) while there is outstanding
pending_exception, pending_complete() forgets to remove
the corresponding exception from its exception table before freeing it.

Already fixed in 2.6.19.

Signed-off-by: Milan Broz <[email protected]>
Signed-off-by: Chris Wright <[email protected]>
---
drivers/md/dm-snap.c | 1 +
1 file changed, 1 insertion(+)

--- linux-2.6.18.5.orig/drivers/md/dm-snap.c
+++ linux-2.6.18.5/drivers/md/dm-snap.c
@@ -691,6 +691,7 @@ static void pending_complete(struct pend

free_exception(e);

+ remove_exception(&pe->e);
error_snapshot_bios(pe);
goto out;
}

--